Clear cmd/archie-agent golangci-lint baseline #482

Closed
opened 2026-10-27 13:36:30 +00:00 by sam · 0 comments
Owner

Problem\nFull-package golangci-lint currently reports findings in cmd/archie-agent, including noctx in taskrun_test.go. This prevents using a clean package lint gate while refactoring main.go.\n\n## Scope\nFix evidence-backed golangci-lint findings in cmd/archie-agent without weakening lint configuration or changing runtime behavior. Coordinate with the MCP extraction where that extraction removes the startMCPProviders complexity finding.\n\n## Acceptance\n- golangci-lint run ./cmd/archie-agent/... reports zero findings\n- focused tests, vet, build, formatting, and task check pass\n- no lint suppressions or configuration exclusions are added

Acceptance criteria

cmd/archie-agent full-package lint is zero with no suppressions; tests, vet, build and task check pass

Notes

Implementation and validation are complete in /tmp/archie-core-agent-cleanup on branch refactor/archie-agent-main-cleanup, but delivery is pending: changes are uncommitted, not integrated into the target branch, and not pushed. Do not close until those delivery steps are complete.
Validation completed: golangci-lint run ./cmd/archie-agent/... reports zero issues without suppressions.
Delivered on review branch refactor/archie-agent-main-cleanup at de242f8; pending PR review/merge.

Close reason

Merged to main in PR #480 at 52738f5; implementation commit de242f8 passed task check, race tests, lint, and independent review


Imported from beads archie-core-tje.5 · GitHub #493 · type task · priority P2 · created 2026-08-13 · closed 2026-08-14

## Problem\nFull-package golangci-lint currently reports findings in cmd/archie-agent, including noctx in taskrun_test.go. This prevents using a clean package lint gate while refactoring main.go.\n\n## Scope\nFix evidence-backed golangci-lint findings in cmd/archie-agent without weakening lint configuration or changing runtime behavior. Coordinate with the MCP extraction where that extraction removes the startMCPProviders complexity finding.\n\n## Acceptance\n- golangci-lint run ./cmd/archie-agent/... reports zero findings\n- focused tests, vet, build, formatting, and task check pass\n- no lint suppressions or configuration exclusions are added ### Acceptance criteria cmd/archie-agent full-package lint is zero with no suppressions; tests, vet, build and task check pass ### Notes Implementation and validation are complete in /tmp/archie-core-agent-cleanup on branch refactor/archie-agent-main-cleanup, but delivery is pending: changes are uncommitted, not integrated into the target branch, and not pushed. Do not close until those delivery steps are complete. Validation completed: golangci-lint run ./cmd/archie-agent/... reports zero issues without suppressions. Delivered on review branch refactor/archie-agent-main-cleanup at de242f8; pending PR review/merge. ### Close reason Merged to main in PR #480 at 52738f5; implementation commit de242f8 passed task check, race tests, lint, and independent review --- _Imported from beads `archie-core-tje.5` · GitHub #493 · type task · priority P2 · created 2026-08-13 · closed 2026-08-14_
sam added the mediumtask labels 2026-10-27 13:36:30 +00:00
sam self-assigned this 2026-10-27 13:36:30 +00:00
sam closed this issue 2026-10-27 13:36:30 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#482