P2 findings from the qdbo.1 adversarial re-review (all non-blocking):
daemon.worktreeHoldsUncapturedWork treats any os.Stat error as not-on-disk and falls through to Cleanup; keep on non-fs.ErrNotExist errors so the fail-closed comment matches the code.
A worktree the cleanliness guard keeps has no reap path or operator-visible handle; archiving the task removes the row and logs while the clone stays.
TestProcessCleansWorktreeOnTerminalNoChange still reports merged and reaches it through a faked pr_open hop, so it models no real producer.
outcome_sites_test.go scans only internal/domain/workflow; taskactions and archied status writers are untied to the transition table.
executionTransitions and Actions()/CheckDecline encode the same rules in one package with no test tying them.
internal/webui/api_tasks_actions_test.go's want map omits completed, so lifecycle-action coverage misses the status this change introduced.
internal/infrastructure/staterpc/conformance_test.go performs a queued->queued write via RetryTask; qdbo.5 enforcement must decide self-transitions.
docs/architecture/agent-system.md:314 still hazards that no enforced state machine exists; revisit when qdbo.5 lands.
Close reason
061816ac; items 2-3 moved to new child bead
Imported from beads archie-core-qdbo.8 · GitHub #1227 · type task · priority P2 · created 2026-09-25 · closed 2026-09-27
P2 findings from the qdbo.1 adversarial re-review (all non-blocking):
1. daemon.worktreeHoldsUncapturedWork treats any os.Stat error as not-on-disk and falls through to Cleanup; keep on non-fs.ErrNotExist errors so the fail-closed comment matches the code.
2. A worktree the cleanliness guard keeps has no reap path or operator-visible handle; archiving the task removes the row and logs while the clone stays.
3. TestProcessCleansWorktreeOnTerminalNoChange still reports merged and reaches it through a faked pr_open hop, so it models no real producer.
4. outcome_sites_test.go scans only internal/domain/workflow; taskactions and archied status writers are untied to the transition table.
5. executionTransitions and Actions()/CheckDecline encode the same rules in one package with no test tying them.
6. internal/webui/api_tasks_actions_test.go's want map omits completed, so lifecycle-action coverage misses the status this change introduced.
7. internal/infrastructure/staterpc/conformance_test.go performs a queued->queued write via RetryTask; qdbo.5 enforcement must decide self-transitions.
8. docs/architecture/agent-system.md:314 still hazards that no enforced state machine exists; revisit when qdbo.5 lands.
### Close reason
061816ac; items 2-3 moved to new child bead
---
_Imported from beads `archie-core-qdbo.8` · GitHub #1227 · type task · priority P2 · created 2026-09-25 · closed 2026-09-27_
sam
added the mediumtask labels 2026-10-27 13:36:10 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
P2 findings from the qdbo.1 adversarial re-review (all non-blocking):
Close reason
061816ac; items 2-3 moved to new child bead
Imported from beads
archie-core-qdbo.8· GitHub #1227 · type task · priority P2 · created 2026-09-25 · closed 2026-09-27