Decide the Settings save model: atomic multi-section save and restart action #362

Closed
opened 2026-10-27 13:36:00 +00:00 by sam · 0 comments
Owner

README section 5.2 and 9 backend questions. Known: restart_required is per field (ui/src/settings/types.ts); no restart RPC exists (archie-core-oif3). Open: can several sections save atomically as one config version, or sequentially with partial-failure handling; does 'Save & restart' degrade to Save plus a persistent Restart pending banner. Also settle max_steps = 0, zero rate-limit semantics, and whether webhook addr is webhook-channel-only.

Design

DECISION (save model).

  1. Atomic multi-section save: NO. The save unit is one resource kind: POST /api/control-plane/resources/{kind}/commands/replace with ExpectedVersion (internal/app/controlplane/controlplane.go:152), and each kind has its own version. Building a cross-kind transaction is not worth it for a solo deployment. The review drawer saves dirty sections in sidebar order, one command each, and stops at the first failure: saved sections show their new version, the failed one stays dirty with its error, the rest stay dirty and untouched. A stale-version rejection reloads that section and shows the diff again. Copy change: drop "saved together as config version N+1"; show "N sections, each gets its own version".
  2. Restart scope: per SECTION, not per field. ResourceDescriptor.apply_mode is live | restart-required | domain-managed per kind (every operational kind is restart-required: operational_settings.go:44-53, model_settings.go:26-27). The per-field restart_required flag belongs only to the legacy config_schema catalog (Daemon section).
  3. Restart action: NONE, and there won't be one from the UI: systemd is optional, so nothing guarantees the process comes back (oif3 stays parked). "Save & restart" becomes "Save", followed by a persistent "Restart pending" banner. That banner comes from apply-status (docs/prds/control-plane-apply-status.md): pending while any reporting process runs an older version of a restart-required kind than the one stored. Never infer it from the UI's own save.
  4. max_steps = 0 means the DEFAULT (100, internal/app/archied/main.go:58), NOT no limit. The hint is "0 uses the default (100)".
  5. Rate limit: off unless BOTH window and max_requests are positive (config.go RateLimitConfig). The handoff's "Off while either value is 0" is correct.
  6. webhook_addr in channel-settings is the chat webhook gateway's listener, so it belongs in the Webhook channel card. The forge's own webhook_addr (forge intake) is a separate field and does not move there.

Acceptance criteria

Written answer per question with file:line evidence; follow-up backend beads filed for any gap.

Close reason

done


Imported from beads archie-core-micl.3 · GitHub #1011 · type decision · priority P1 · created 2026-09-25 · closed 2026-09-28

README section 5.2 and 9 backend questions. Known: restart_required is per field (ui/src/settings/types.ts); no restart RPC exists (archie-core-oif3). Open: can several sections save atomically as one config version, or sequentially with partial-failure handling; does 'Save & restart' degrade to Save plus a persistent Restart pending banner. Also settle max_steps = 0, zero rate-limit semantics, and whether webhook addr is webhook-channel-only. ### Design DECISION (save model). 1. Atomic multi-section save: NO. The save unit is one resource kind: POST /api/control-plane/resources/{kind}/commands/replace with ExpectedVersion (internal/app/controlplane/controlplane.go:152), and each kind has its own version. Building a cross-kind transaction is not worth it for a solo deployment. The review drawer saves dirty sections in sidebar order, one command each, and stops at the first failure: saved sections show their new version, the failed one stays dirty with its error, the rest stay dirty and untouched. A stale-version rejection reloads that section and shows the diff again. Copy change: drop "saved together as config version N+1"; show "N sections, each gets its own version". 2. Restart scope: per SECTION, not per field. ResourceDescriptor.apply_mode is live | restart-required | domain-managed per kind (every operational kind is restart-required: operational_settings.go:44-53, model_settings.go:26-27). The per-field restart_required flag belongs only to the legacy config_schema catalog (Daemon section). 3. Restart action: NONE, and there won't be one from the UI: systemd is optional, so nothing guarantees the process comes back (oif3 stays parked). "Save & restart" becomes "Save", followed by a persistent "Restart pending" banner. That banner comes from apply-status (docs/prds/control-plane-apply-status.md): pending while any reporting process runs an older version of a restart-required kind than the one stored. Never infer it from the UI's own save. 4. max_steps = 0 means the DEFAULT (100, internal/app/archied/main.go:58), NOT no limit. The hint is "0 uses the default (100)". 5. Rate limit: off unless BOTH window and max_requests are positive (config.go RateLimitConfig). The handoff's "Off while either value is 0" is correct. 6. webhook_addr in channel-settings is the chat webhook gateway's listener, so it belongs in the Webhook channel card. The forge's own webhook_addr (forge intake) is a separate field and does not move there. ### Acceptance criteria Written answer per question with file:line evidence; follow-up backend beads filed for any gap. ### Close reason done --- _Imported from beads `archie-core-micl.3` · GitHub #1011 · type decision · priority P1 · created 2026-09-25 · closed 2026-09-28_
sam added the highdecision labels 2026-10-27 13:36:00 +00:00
sam self-assigned this 2026-10-27 13:36:00 +00:00
sam closed this issue 2026-10-27 13:36:00 +00:00
sam added a new dependency 2026-10-27 13:41:54 +00:00
sam added a new dependency 2026-10-27 13:42:24 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#362