Config schema completeness tests hand-maintain an exhaustive key list that must be touched on every new field #263

Closed
opened 2026-10-27 13:35:37 +00:00 by sam · 0 comments
Owner

internal/webui/config_schema_test.go's TestConfigFieldDescriptorsAreComplete (exact 15-key wantKeys list, len(seen) != len(wantKeys)) and TestConfigFieldDescriptorsRestartRequiredIsDeliberate (a hand-maintained bool per field) are self-documented as deliberate forcing functions, not oversights -- each new config field must be added to these lists or the test fails. That is a legitimate way to prevent silent schema drift, but it is also a compounding, hand-maintained cost that scales with the config surface. Worth a design call: keep as-is, or replace with a check that derives its expectation from a single source of truth (e.g. the actual settings.js dotted-key set) instead of two independently maintained literal lists.

Close reason

Closed on GitHub; syncing bead state


Imported from beads archie-core-gnzh.3 · GitHub #1231 · type task · priority P3 · created 2026-09-26 · closed 2026-09-26

internal/webui/config_schema_test.go's TestConfigFieldDescriptorsAreComplete (exact 15-key wantKeys list, len(seen) != len(wantKeys)) and TestConfigFieldDescriptorsRestartRequiredIsDeliberate (a hand-maintained bool per field) are self-documented as deliberate forcing functions, not oversights -- each new config field must be added to these lists or the test fails. That is a legitimate way to prevent silent schema drift, but it is also a compounding, hand-maintained cost that scales with the config surface. Worth a design call: keep as-is, or replace with a check that derives its expectation from a single source of truth (e.g. the actual settings.js dotted-key set) instead of two independently maintained literal lists. ### Close reason Closed on GitHub; syncing bead state --- _Imported from beads `archie-core-gnzh.3` · GitHub #1231 · type task · priority P3 · created 2026-09-26 · closed 2026-09-26_
sam added the lowtask labels 2026-10-27 13:35:37 +00:00
sam self-assigned this 2026-10-27 13:35:37 +00:00
sam closed this issue 2026-10-27 13:35:37 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#263