TestConfigForTaskJSONRoundTrip pins TaskConfig's and Forge's exact JSON key sets #262

Closed
opened 2026-10-27 13:35:36 +00:00 by sam · 0 comments
Owner

internal/config/config_test.go's TestConfigForTaskJSONRoundTrip asserts an exact key list via assertJSONKeys(...) for the whole TaskConfig payload, and reflect.DeepEqual's the forge payload against a map containing only {"host": ...}. Adding any new optional field to TaskConfig or config.Forge -- for a reason unrelated to whatever this test guards -- breaks it. Consider asserting only the specific keys the round-trip test cares about (the ones it actually inspects afterward: budgets.wall_clock, forge.host) rather than the complete set.

Close reason

Closed on GitHub; syncing bead state


Imported from beads archie-core-gnzh.2 · GitHub #1230 · type task · priority P3 · created 2026-09-26 · closed 2026-09-26

internal/config/config_test.go's TestConfigForTaskJSONRoundTrip asserts an exact key list via assertJSONKeys(...) for the whole TaskConfig payload, and reflect.DeepEqual's the forge payload against a map containing only {"host": ...}. Adding any new optional field to TaskConfig or config.Forge -- for a reason unrelated to whatever this test guards -- breaks it. Consider asserting only the specific keys the round-trip test cares about (the ones it actually inspects afterward: budgets.wall_clock, forge.host) rather than the complete set. ### Close reason Closed on GitHub; syncing bead state --- _Imported from beads `archie-core-gnzh.2` · GitHub #1230 · type task · priority P3 · created 2026-09-26 · closed 2026-09-26_
sam added the lowtask labels 2026-10-27 13:35:36 +00:00
sam self-assigned this 2026-10-27 13:35:36 +00:00
sam closed this issue 2026-10-27 13:35:36 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#262