Container image default duplicated as a literal instead of referencing defaultContainerImage #261

Closed
opened 2026-10-27 13:35:36 +00:00 by sam · 0 comments
Owner

internal/infrastructure/configuration/defaults_test.go:37 (TestApplyContainerDefaultsMakesManagedWorkersReadyByDefault) hardcodes const wantImage = "ghcr.io/samcharles93/archie-agent:latest" instead of asserting against the production defaultContainerImage constant already defined at defaults.go:26. No functional risk today, but the two copies can silently drift: changing the real default would not be caught by this test at all (it would just start failing for the wrong reason -- a mismatch against a stale duplicate, not a check that the default is still X). Fix: reference the constant.

Close reason

Closed on GitHub; syncing bead state


Imported from beads archie-core-gnzh.1 · GitHub #1232 · type task · priority P3 · created 2026-09-26 · closed 2026-09-26

internal/infrastructure/configuration/defaults_test.go:37 (TestApplyContainerDefaultsMakesManagedWorkersReadyByDefault) hardcodes const wantImage = "ghcr.io/samcharles93/archie-agent:latest" instead of asserting against the production defaultContainerImage constant already defined at defaults.go:26. No functional risk today, but the two copies can silently drift: changing the real default would not be caught by this test at all (it would just start failing for the wrong reason -- a mismatch against a stale duplicate, not a check that the default is still X). Fix: reference the constant. ### Close reason Closed on GitHub; syncing bead state --- _Imported from beads `archie-core-gnzh.1` · GitHub #1232 · type task · priority P3 · created 2026-09-26 · closed 2026-09-26_
sam added the lowtask labels 2026-10-27 13:35:36 +00:00
sam self-assigned this 2026-10-27 13:35:36 +00:00
sam closed this issue 2026-10-27 13:35:36 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#261