internal/infrastructure/configuration/defaults_test.go:37 (TestApplyContainerDefaultsMakesManagedWorkersReadyByDefault) hardcodes const wantImage = "ghcr.io/samcharles93/archie-agent:latest" instead of asserting against the production defaultContainerImage constant already defined at defaults.go:26. No functional risk today, but the two copies can silently drift: changing the real default would not be caught by this test at all (it would just start failing for the wrong reason -- a mismatch against a stale duplicate, not a check that the default is still X). Fix: reference the constant.
Close reason
Closed on GitHub; syncing bead state
Imported from beads archie-core-gnzh.1 · GitHub #1232 · type task · priority P3 · created 2026-09-26 · closed 2026-09-26
internal/infrastructure/configuration/defaults_test.go:37 (TestApplyContainerDefaultsMakesManagedWorkersReadyByDefault) hardcodes const wantImage = "ghcr.io/samcharles93/archie-agent:latest" instead of asserting against the production defaultContainerImage constant already defined at defaults.go:26. No functional risk today, but the two copies can silently drift: changing the real default would not be caught by this test at all (it would just start failing for the wrong reason -- a mismatch against a stale duplicate, not a check that the default is still X). Fix: reference the constant.
### Close reason
Closed on GitHub; syncing bead state
---
_Imported from beads `archie-core-gnzh.1` · GitHub #1232 · type task · priority P3 · created 2026-09-26 · closed 2026-09-26_
sam
added the lowtask labels 2026-10-27 13:35:36 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
internal/infrastructure/configuration/defaults_test.go:37 (TestApplyContainerDefaultsMakesManagedWorkersReadyByDefault) hardcodes const wantImage = "ghcr.io/samcharles93/archie-agent:latest" instead of asserting against the production defaultContainerImage constant already defined at defaults.go:26. No functional risk today, but the two copies can silently drift: changing the real default would not be caught by this test at all (it would just start failing for the wrong reason -- a mismatch against a stale duplicate, not a check that the default is still X). Fix: reference the constant.
Close reason
Closed on GitHub; syncing bead state
Imported from beads
archie-core-gnzh.1· GitHub #1232 · type task · priority P3 · created 2026-09-26 · closed 2026-09-26