message.send needs a connector that declares the chat_message delivery #2085

Closed
opened 2026-11-21 04:02:13 +00:00 by sam · 1 comment
Owner

message.send (#2044) delivers through deliveries.Module.Send, which calls a connector delivery named chat_message with {chat_id, text}. No connector declares that delivery yet, so a workflow using message.send saves and runs but fails at the send. That breaks the rule that a setting must work end to end.

Either the messaging connectors (Telegram first) declare chat_message, or Send is built on a delivery they already declare. Pick whichever keeps one contract.

Done when: a workflow with a message.send step delivers its text to a Telegram chat, and a connector that can't address a chat is refused when the workflow is saved, not when the step runs.

`message.send` (#2044) delivers through `deliveries.Module.Send`, which calls a connector delivery named `chat_message` with `{chat_id, text}`. No connector declares that delivery yet, so a workflow using `message.send` saves and runs but fails at the send. That breaks the rule that a setting must work end to end. Either the messaging connectors (Telegram first) declare `chat_message`, or `Send` is built on a delivery they already declare. Pick whichever keeps one contract. Done when: a workflow with a `message.send` step delivers its text to a Telegram chat, and a connector that can't address a chat is refused when the workflow is saved, not when the step runs.
sam added the highbug labels 2026-11-21 04:02:13 +00:00
Author
Owner

Fixed in archie-core 35e2a216a, and in archipelago 6fec208 and 8733752.

  • Contract: chat_message ({chat_id, text}) stays and the Telegram connector now declares it. The existing message delivery writes to every allowed user and can't name one chat, so Send couldn't be built on it without changing what Notify does. chat_id must belong to an allowed user. Any other chat is a permanent rejection, so a workflow can't make the bot message anyone else. Long text is split the same way as message.
  • Save-time check: when a workflow is saved, and for a dry run, each message.send step's channel must be a running connector that declares chat_message. Otherwise the save is refused with a problem at steps[i].settings.channel.

Verified: a new table test, TestSavingChecksMessageChannel, has an accepted case and a refused case. The refusal case failed with the check disabled. The archipelago Telegram tests cover an allowed chat, another chat and a non-numeric id. task check passed on the merged archie-core tree. Not verified: a live send to Telegram on staging.

Fixed in archie-core 35e2a216a, and in archipelago 6fec208 and 8733752. - Contract: `chat_message` (`{chat_id, text}`) stays and the Telegram connector now declares it. The existing `message` delivery writes to every allowed user and can't name one chat, so `Send` couldn't be built on it without changing what `Notify` does. `chat_id` must belong to an allowed user. Any other chat is a permanent rejection, so a workflow can't make the bot message anyone else. Long text is split the same way as `message`. - Save-time check: when a workflow is saved, and for a dry run, each `message.send` step's channel must be a running connector that declares `chat_message`. Otherwise the save is refused with a problem at `steps[i].settings.channel`. Verified: a new table test, `TestSavingChecksMessageChannel`, has an accepted case and a refused case. The refusal case failed with the check disabled. The archipelago Telegram tests cover an allowed chat, another chat and a non-numeric id. `task check` passed on the merged archie-core tree. Not verified: a live send to Telegram on staging.
sam closed this issue 2026-11-21 04:22:05 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#2085