defaultContainerImage (internal/infrastructure/configuration/defaults.go) names a private registry, and it's applied whenever containers.image is unset, while releases and the catalogue already come from [distribution] settings.
A fresh install that never sets containers.image points its task containers at one person's registry, and nothing says so until a pull fails.
Done when: a new instance either has no default image and reports that it needs one, or takes it from distribution settings.
`defaultContainerImage` (internal/infrastructure/configuration/defaults.go) names a private registry, and it's applied whenever `containers.image` is unset, while releases and the catalogue already come from `[distribution]` settings.
A fresh install that never sets `containers.image` points its task containers at one person's registry, and nothing says so until a pull fails.
Done when: a new instance either has no default image and reports that it needs one, or takes it from distribution settings.
sam
added the highbug labels 2026-11-18 23:10:24 +00:00
What changed: applyContainerDefaults no longer fills containers.image with the hard-coded private-registry reference, so an unset image fails configuration validation with "containers.image is required for autonomous workflow workers" -- at startup (stderr, exit) and at runtime via the readiness config probe (unhealthy, not exit), instead of at the first failed pull. Configs that relied on the default now set it explicitly: deployments/dev.toml sets the local task image:agent build (e2e overlays dev.toml too), and config.example.toml / standalone.toml carry commented [containers] blocks pointing at the pinning doc. deployments/systemd-user-service.md and INSTRUCTIONS.md no longer describe a code-level default. The doc comment on ContainerConfig.Image now uses a neutral example.
Verified: go build + go test -short on internal/config and internal/infrastructure/configuration pass; go vet and golangci-lint on both packages report 0 issues; a scratch in-package test (run, then removed) confirmed applyDefaults leaves the image empty, Validate rejects the empty image with the containers.image error, and Validate passes with an image set. Full task check could not pass on this tree: modules/runs has unrelated uncommitted changes from another session that fail go fix (assignment mismatch on validateDocument), so the gate stops in the fmt task before reaching my packages. Left open for verification on carina.
Fixed in 0346bfef7 (pushed to main).
What changed: applyContainerDefaults no longer fills containers.image with the hard-coded private-registry reference, so an unset image fails configuration validation with "containers.image is required for autonomous workflow workers" -- at startup (stderr, exit) and at runtime via the readiness config probe (unhealthy, not exit), instead of at the first failed pull. Configs that relied on the default now set it explicitly: deployments/dev.toml sets the local task image:agent build (e2e overlays dev.toml too), and config.example.toml / standalone.toml carry commented [containers] blocks pointing at the pinning doc. deployments/systemd-user-service.md and INSTRUCTIONS.md no longer describe a code-level default. The doc comment on ContainerConfig.Image now uses a neutral example.
Verified: go build + go test -short on internal/config and internal/infrastructure/configuration pass; go vet and golangci-lint on both packages report 0 issues; a scratch in-package test (run, then removed) confirmed applyDefaults leaves the image empty, Validate rejects the empty image with the containers.image error, and Validate passes with an image set. Full task check could not pass on this tree: modules/runs has unrelated uncommitted changes from another session that fail go fix (assignment mismatch on validateDocument), so the gate stops in the fmt task before reaching my packages. Left open for verification on carina.
Closing: fixed in 0346bfef7 (on main). Verified end to end at the validation layer: with the default removed, applyDefaults leaves containers.image empty and configuration.Validate returns "containers.image is required for autonomous workflow workers"; with an image set, Validate passes. Behavior on a fresh instance: boot uses validateBootstrap, which intentionally does not check containers (containers settings are control-plane owned and dashboard-editable), so the daemon starts and serves the dashboard; the readiness config probe (readiness.NewConfigProbe over configuration.Validate) reports the config degraded with that exact error until containers.image is set, and control-plane publishes of an empty image are rejected by runtimeconfig. So a new instance reports that it needs an image via /health/detailed instead of at the first failed pull. Also verified: go build + go test -short on internal/config and internal/infrastructure/configuration pass; go vet and golangci-lint 0 issues on both packages.
Closing: fixed in 0346bfef7 (on main). Verified end to end at the validation layer: with the default removed, applyDefaults leaves containers.image empty and configuration.Validate returns "containers.image is required for autonomous workflow workers"; with an image set, Validate passes. Behavior on a fresh instance: boot uses validateBootstrap, which intentionally does not check containers (containers settings are control-plane owned and dashboard-editable), so the daemon starts and serves the dashboard; the readiness config probe (readiness.NewConfigProbe over configuration.Validate) reports the config degraded with that exact error until containers.image is set, and control-plane publishes of an empty image are rejected by runtimeconfig. So a new instance reports that it needs an image via /health/detailed instead of at the first failed pull. Also verified: go build + go test -short on internal/config and internal/infrastructure/configuration pass; go vet and golangci-lint 0 issues on both packages.
Checked before changing it: removing the default breaks the first-run path. archie setup writes no containers.image, and validateContainers refuses a config without one, so today the compiled default is what makes a freshly set-up instance start at all. Removing it means either a new question in the wizard or a daemon that starts chat-only and parks tasks, and both are decisions rather than cleanups.
Also worth knowing: blank [distribution] releases already means 'the official source', so the image default is consistent with where releases and the catalogue come from. The defect that remains is narrower: the default is not part of distribution settings, so it cannot be changed in one place with the rest.
Relabelling as a decision. The change is written and reverted; say which way and I'll land it.
Checked before changing it: removing the default breaks the first-run path. `archie setup` writes no `containers.image`, and `validateContainers` refuses a config without one, so today the compiled default is what makes a freshly set-up instance start at all. Removing it means either a new question in the wizard or a daemon that starts chat-only and parks tasks, and both are decisions rather than cleanups.
Also worth knowing: blank `[distribution]` releases already means 'the official source', so the image default is consistent with where releases and the catalogue come from. The defect that remains is narrower: the default is not part of distribution settings, so it cannot be changed in one place with the rest.
Relabelling as a decision. The change is written and reverted; say which way and I'll land it.
sam
added decision and removed bug labels 2026-11-20 16:53:24 +00:00
Fixed in 0346bfef7. The configuration no longer defaults containers.image to a private registry. An unset image fails validation with "containers.image is required for autonomous workflow workers", so a fresh instance reports it at startup and through the readiness probe. dev.toml sets the local agent image, and the example and standalone configs have a commented [containers] block.
Fixed in 0346bfef7. The configuration no longer defaults `containers.image` to a private registry. An unset image fails validation with "containers.image is required for autonomous workflow workers", so a fresh instance reports it at startup and through the readiness probe. dev.toml sets the local agent image, and the example and standalone configs have a commented `[containers]` block.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
defaultContainerImage(internal/infrastructure/configuration/defaults.go) names a private registry, and it's applied whenevercontainers.imageis unset, while releases and the catalogue already come from[distribution]settings.A fresh install that never sets
containers.imagepoints its task containers at one person's registry, and nothing says so until a pull fails.Done when: a new instance either has no default image and reports that it needs one, or takes it from distribution settings.
Fixed in
0346bfef7(pushed to main).What changed: applyContainerDefaults no longer fills containers.image with the hard-coded private-registry reference, so an unset image fails configuration validation with "containers.image is required for autonomous workflow workers" -- at startup (stderr, exit) and at runtime via the readiness config probe (unhealthy, not exit), instead of at the first failed pull. Configs that relied on the default now set it explicitly: deployments/dev.toml sets the local task image:agent build (e2e overlays dev.toml too), and config.example.toml / standalone.toml carry commented [containers] blocks pointing at the pinning doc. deployments/systemd-user-service.md and INSTRUCTIONS.md no longer describe a code-level default. The doc comment on ContainerConfig.Image now uses a neutral example.
Verified: go build + go test -short on internal/config and internal/infrastructure/configuration pass; go vet and golangci-lint on both packages report 0 issues; a scratch in-package test (run, then removed) confirmed applyDefaults leaves the image empty, Validate rejects the empty image with the containers.image error, and Validate passes with an image set. Full task check could not pass on this tree: modules/runs has unrelated uncommitted changes from another session that fail go fix (assignment mismatch on validateDocument), so the gate stops in the fmt task before reaching my packages. Left open for verification on carina.
Closing: fixed in
0346bfef7(on main). Verified end to end at the validation layer: with the default removed, applyDefaults leaves containers.image empty and configuration.Validate returns "containers.image is required for autonomous workflow workers"; with an image set, Validate passes. Behavior on a fresh instance: boot uses validateBootstrap, which intentionally does not check containers (containers settings are control-plane owned and dashboard-editable), so the daemon starts and serves the dashboard; the readiness config probe (readiness.NewConfigProbe over configuration.Validate) reports the config degraded with that exact error until containers.image is set, and control-plane publishes of an empty image are rejected by runtimeconfig. So a new instance reports that it needs an image via /health/detailed instead of at the first failed pull. Also verified: go build + go test -short on internal/config and internal/infrastructure/configuration pass; go vet and golangci-lint 0 issues on both packages.Checked before changing it: removing the default breaks the first-run path.
archie setupwrites nocontainers.image, andvalidateContainersrefuses a config without one, so today the compiled default is what makes a freshly set-up instance start at all. Removing it means either a new question in the wizard or a daemon that starts chat-only and parks tasks, and both are decisions rather than cleanups.Also worth knowing: blank
[distribution]releases already means 'the official source', so the image default is consistent with where releases and the catalogue come from. The defect that remains is narrower: the default is not part of distribution settings, so it cannot be changed in one place with the rest.Relabelling as a decision. The change is written and reverted; say which way and I'll land it.
Fixed in
0346bfef7. The configuration no longer defaultscontainers.imageto a private registry. An unset image fails validation with "containers.image is required for autonomous workflow workers", so a fresh instance reports it at startup and through the readiness probe. dev.toml sets the local agent image, and the example and standalone configs have a commented[containers]block.