Model-facing tool descriptions and prompt fragments are Go literals #2051

Open
opened 2026-11-18 23:10:24 +00:00 by sam · 1 comment
Owner

AGENTS.md requires every instruction sent to a model to be a file in internal/prompts, and the 19 prompt files there do that. The rest doesn't:

  • 72 Description: strings on tool entries (61 of them in internal/gateway), with the parameter descriptions beside them.
  • 10 workflow parameter descriptions in internal/domain/workflow.
  • Three prompts written straight into Go: ProjectScopedRules (internal/agentexec/helpers.go), the PR-review adversary prompt (internal/domain/workflow/prreview_stages_verify.go), the governance probe (modules/governance/governance.go).

Wording changes need a rebuild and can't be reviewed beside the prompt files.

Done when: every instruction and schema description the model reads comes from a file in internal/prompts, like the 19 that already do.

AGENTS.md requires every instruction sent to a model to be a file in internal/prompts, and the 19 prompt files there do that. The rest doesn't: - 72 `Description:` strings on tool entries (61 of them in internal/gateway), with the parameter descriptions beside them. - 10 workflow parameter descriptions in internal/domain/workflow. - Three prompts written straight into Go: `ProjectScopedRules` (internal/agentexec/helpers.go), the PR-review adversary prompt (internal/domain/workflow/prreview_stages_verify.go), the governance probe (modules/governance/governance.go). Wording changes need a rebuild and can't be reviewed beside the prompt files. Done when: every instruction and schema description the model reads comes from a file in internal/prompts, like the 19 that already do.
sam added the choremedium labels 2026-11-18 23:10:24 +00:00
Author
Owner

Three of these were the rule proper and are now files (ee66e4f0f): the workspace scoping rule, the PR-review adversary mission and the model probe. They render the same bytes the Go concatenations built. The probe lives in internal/platform/prompts, which is where a module reads prompts from.

What remains is the 82 schema descriptions: 72 tool Description: strings (61 in internal/gateway) and 10 workflow parameter descriptions. Those are structured data attached to tool definitions, so moving them wants a catalogue the tool registry reads, not one file per string. Left open for that.

Three of these were the rule proper and are now files (ee66e4f0f): the workspace scoping rule, the PR-review adversary mission and the model probe. They render the same bytes the Go concatenations built. The probe lives in internal/platform/prompts, which is where a module reads prompts from. What remains is the 82 schema descriptions: 72 tool `Description:` strings (61 in internal/gateway) and 10 workflow parameter descriptions. Those are structured data attached to tool definitions, so moving them wants a catalogue the tool registry reads, not one file per string. Left open for that.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#2051