Workflow documents use today's step shape, references and when on the durable engine #2039
Notifications
Due Date
No due date set.
Blocks
Reference: sam/archie#2039
Reference in new issue
Block a user
Child of #2037. Plan: workflow vocabulary on the durable engine, one requirement per child.
The document becomes today's shape:
id/type/settingswithwhenandon_failure, a step-type registry with strict per-type settings, workflow-levelinputs,repository,instructions,identityandprofile, and{{ }}references (rootstask,inputs,steps) checked at save. The five kinds become types:agent.run(inline mission, memory),connector.action,approval.wait,run.notify,workflow.sleep. Results are kept per step; any number of approval waits; actions still held at the end get settled before the run finishes.retry,switch,parallelandoutputsare refused until their children land. A run of a workflow naming an identity or profile is refused at start until identity (#2017) or task runs (#2020) land. List, get and save endpoints for workflows and a step-type catalog; the editor page is the first page of #2029.Done when: the corpus table test passes with each old document marked valid or refused for a named reason, investigate runs on fakes in the new format, and staging runs investigate after its stored documents are rewritten.
Landed in
ce70d4f3e:inputs,repository,instructions,identityandprofileare declared, and steps areid/type/settingswithwhenandon_failure.agent.run(inline mission, memory),connector.action,approval.wait,run.notify,workflow.sleep.{{ task|inputs|steps }}references are checked at save. The run input is read asinputs.event.GET/PUT /api/workflows/{name},GET /api/workflowsandGET /api/workflow-step-types.Verified:
TestCorpusChecksAsItsStepTypesLand: the six old shipped documents and the old reference rules. Each old document is refused only for types or settings that a later child or #2020/#2034 adds.TestDocumentStepsRunon fakes: rendering, when, continue, the end-of-run settle, and one ask per action.task checkpasses.Still to do: deploy to staging and rewrite the stored bodies in place, which needs the maintainer's OK.
The local gaps are closed in 90637aa45; staging is the remaining step.
What changed:
Verified through the single binary against a disposable database: the step catalog; list/get/save; field-specific 400s for an unknown type, retry, parallel, switch, outputs and a dotted id; a rejected save creates no version; an identity document saves but its trigger is refused; a startable workflow accepts a trigger. task check passes on the commit.
Staging, which this issue still needs: