Cross-check the daemon before any of it is split or deleted #2038
Notifications
Due Date
No due date set.
Blocks
Reference: sam/archie#2038
Reference in new issue
Block a user
internal/daemon(4,732 lines) is archied's resident loop. The move map once marked it "split: parts superseded, task bus and drain go" without a cross-check. Nothing in it is split, superseded or deleted until each responsibility below has been compared with the single binary and the maintainer has approved the result.Responsibilities to cross-check, file by file:
pipeline.go: resolving a run's repository, credentials and permissions.container_run.go,runtime.go,model_egress.go: the sandbox a task's agent runs in, its egress session and model access.issue_poll.go,review_scan.go,reactions.go,pr_review_prefetch.go: forge work discovery, review reactions, prefetching PR reviews.binding_dispatch.go,binding_target.go: dispatching captured events to bindings (#2032).identity.go,workflow_identity.go,workflow_org.go: who an identity is, which organisation it acts for, whether it may act.pinning.go,package_tools.go,package_trigger.go: workflow definition pinning, package authority over tools, package triggers.task_bus.go,running.go,call_waits.go,park.go,lifecycle.go: dispatch, capacity, stop, call waits, parks, startup recovery and the watchdog (the lifecycle part is #2036 and #2020).builtin_jobs.go: instance maintenance jobs.statestore_target.go,agent_status.go,repository_access.go: plumbing to the other services.Done when: each responsibility has a verdict in MIGRATION.md (moved, already covered with evidence, or deleted with the maintainer's approval), and every gap found has an issue.