Review reconciler retries a task whose forge can't resolve every minute, forever #1975

Open
opened 2026-11-14 06:36:46 +00:00 by sam · 1 comment
Owner

Problem

When a reviewed task's forge can't be resolved because its execution identity is not an active bot or service account, the PR reconciler logs "no forge for task" and retries on every pass. The condition is permanent, so it repeats about once a minute indefinitely and the task never leaves review.

Wanted

A forge resolution that fails for a permanent reason (inactive or wrong-kind identity, missing connection) parks the task with a visible reason the operator can act on, and the reconciler stops retrying it until the task or its identity changes. Transient errors keep retrying.

Done when

A task in this state shows the reason in the dashboard, and the daemon log carries one line for it rather than one per pass.

## Problem When a reviewed task's forge can't be resolved because its execution identity is not an active bot or service account, the PR reconciler logs \"no forge for task\" and retries on every pass. The condition is permanent, so it repeats about once a minute indefinitely and the task never leaves review. ## Wanted A forge resolution that fails for a permanent reason (inactive or wrong-kind identity, missing connection) parks the task with a visible reason the operator can act on, and the reconciler stops retrying it until the task or its identity changes. Transient errors keep retrying. ## Done when A task in this state shows the reason in the dashboard, and the daemon log carries one line for it rather than one per pass.
sam added the bugmedium labels 2026-11-14 06:36:52 +00:00
Author
Owner

Landed in a262151cb: switched scanPRReviews onto openPRForge/reconcileForge (sharing forge resolution with reconcilePRs and handling nil forges resolvers), added PROpen -> Parked transition, updated ParkTask comment, and parked pr_open tasks with ParkNeedsDecision and blocker on permanent forge/identity resolution errors while keeping transient failures retrying. Verified with go fix -diff ./... and task check (golangci-lint, go test -short ./..., build, UI build and tests). Leaving open pending deployment and live verification.

Landed in a262151cb: switched scanPRReviews onto openPRForge/reconcileForge (sharing forge resolution with reconcilePRs and handling nil forges resolvers), added PROpen -> Parked transition, updated ParkTask comment, and parked pr_open tasks with ParkNeedsDecision and blocker on permanent forge/identity resolution errors while keeping transient failures retrying. Verified with go fix -diff ./... and task check (golangci-lint, go test -short ./..., build, UI build and tests). Leaving open pending deployment and live verification.
sam added the deferred label 2026-11-15 17:26:08 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1975