e2e: accessibility check fails when the Spotnote dev overlay is loaded #1963

Closed
opened 2026-11-13 11:21:26 +00:00 by sam · 1 comment
Owner

With the spotnote Vite plugin active, getByRole('dialog') in e2e/checks/accessibility.cjs matches the overlay's Notes and Settings dialogs as well as New task, so the check fails on a strict-mode violation before it tests anything. Done when the check scopes its dialog locator (e.g. by name) and passes with the plugin loaded.

With the spotnote Vite plugin active, getByRole('dialog') in e2e/checks/accessibility.cjs matches the overlay's Notes and Settings dialogs as well as New task, so the check fails on a strict-mode violation before it tests anything. Done when the check scopes its dialog locator (e.g. by name) and passes with the plugin loaded.
Author
Owner

Fixed in 104854da2. task check passed on the rebased tree; the e2e check itself was not re-run after the fix.

Fixed in 104854da2. task check passed on the rebased tree; the e2e check itself was not re-run after the fix.
sam closed this issue 2026-11-13 17:11:24 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1963