Workflows: consolidate the folder from 40 files to about 22 #1958

Closed
opened 2026-11-13 02:49:21 +00:00 by sam · 1 comment
Owner

Pure moves, no behaviour change:

  • one runs component replaces the two stage cards, WorkflowBar, stages.ts and labels.ts;
  • fold one-consumer files into their consumer (AddNode, LaneNode, InsertEdge, TranscriptTool, transcript.ts, bind-event.ts, workflow-history.ts, step-icons.ts, TriggerSettings);
  • one run dialog; one shared form shell for event and schedule triggers; one input-spec type and parser instead of four;
  • move OptionSelect.vue to components/ui and work-request.ts to tasks/.
Pure moves, no behaviour change: - one runs component replaces the two stage cards, `WorkflowBar`, `stages.ts` and `labels.ts`; - fold one-consumer files into their consumer (`AddNode`, `LaneNode`, `InsertEdge`, `TranscriptTool`, `transcript.ts`, `bind-event.ts`, `workflow-history.ts`, `step-icons.ts`, `TriggerSettings`); - one run dialog; one shared form shell for event and schedule triggers; one input-spec type and parser instead of four; - move `OptionSelect.vue` to `components/ui` and `work-request.ts` to `tasks/`.
sam added the mediumtask labels 2026-11-13 02:49:21 +00:00
Author
Owner

Done in a5ba2c99, 5b3ae6ab and 925365b2: ui/src/workflows went from 40 files to 28. Deleted or folded: the two stage cards, WorkflowBar, stages.ts, labels.ts (into WorkflowRuns.vue), AddNode and LaneNode (inline canvas slots), TranscriptTool and transcript.ts (into AgentTranscript), workflow-history.ts (into workflow-revisions.ts). Moved out: OptionSelect to components/, work-request.ts to tasks/. One InputSpec type and declaredSpecs() parser replace four. One run dialog (0cfa701f). Kept on purpose: InsertEdge (computes its own edge path), step-icons.ts (workflow-graph.ts is imported by Node tests and must not pull in icons), TriggerSettings (folding it would grow the 650-line editor), and the event/schedule form shells (once both took the server's status, the duplication is a 4-line header and a 10-line transition; a shared shell would add a file to save that). Tests, typecheck and task check passed; canvas, Runs and trigger cards smoke-checked in the browser.

Done in a5ba2c99, 5b3ae6ab and 925365b2: ui/src/workflows went from 40 files to 28. Deleted or folded: the two stage cards, WorkflowBar, stages.ts, labels.ts (into WorkflowRuns.vue), AddNode and LaneNode (inline canvas slots), TranscriptTool and transcript.ts (into AgentTranscript), workflow-history.ts (into workflow-revisions.ts). Moved out: OptionSelect to components/, work-request.ts to tasks/. One InputSpec type and declaredSpecs() parser replace four. One run dialog (0cfa701f). Kept on purpose: InsertEdge (computes its own edge path), step-icons.ts (workflow-graph.ts is imported by Node tests and must not pull in icons), TriggerSettings (folding it would grow the 650-line editor), and the event/schedule form shells (once both took the server's status, the duplication is a 4-line header and a 10-line transition; a shared shell would add a file to save that). Tests, typecheck and task check passed; canvas, Runs and trigger cards smoke-checked in the browser.
sam closed this issue 2026-11-13 03:42:42 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1958