Opening a workflow can create a draft nobody made #1946

Closed
opened 2026-11-13 02:49:19 +00:00 by sam · 1 comment
Owner

load() runs normalizeStepIDs and the yaml watcher persists any difference as a draft, so opening a workflow whose step ids aren't normalised shows "draft changes" the operator never made.

Done when: opening a workflow never writes a draft.

`load()` runs `normalizeStepIDs` and the `yaml` watcher persists any difference as a draft, so opening a workflow whose step ids aren't normalised shows "draft changes" the operator never made. Done when: opening a workflow never writes a draft.
sam added the criticalbug labels 2026-11-13 02:49:19 +00:00
Author
Owner

Not reproducible, closing. normalizeStepIDs only rewrites invalid step ids (uppercase, underscores, dots), and the server refuses a published definition containing one: replacing the definitions with a step id Do_Thing returned 400. So a published workflow always loads unchanged, and opening triage, implement and pr-review with no draft left no draft behind (checked by reading workflow-drafts after each). The only path left is an existing draft with an invalid id being rewritten to a valid one, which edits a draft that already exists rather than creating one.

Not reproducible, closing. normalizeStepIDs only rewrites invalid step ids (uppercase, underscores, dots), and the server refuses a published definition containing one: replacing the definitions with a step id Do_Thing returned 400. So a published workflow always loads unchanged, and opening triage, implement and pr-review with no draft left no draft behind (checked by reading workflow-drafts after each). The only path left is an existing draft with an invalid id being rewritten to a valid one, which edits a draft that already exists rather than creating one.
sam closed this issue 2026-11-13 03:04:58 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1946