Enter in a workflow field, or a Retry button, publishes the draft #1943

Closed
opened 2026-11-13 02:49:19 +00:00 by sam · 1 comment
Owner

The editor is wrapped in <form @submit.prevent="publish"> (WorkflowEditor.vue). Enter in a single-line step field submits it, and Retry buttons in WorkflowSettings.vue and TriggerSettings.vue have no type, so clicking one publishes. publish() also ignores publishBlocked.

Done when: Enter in any editor field and clicking Retry never publish; Publish is a plain button that refuses while publishing is blocked.

The editor is wrapped in `<form @submit.prevent="publish">` (`WorkflowEditor.vue`). Enter in a single-line step field submits it, and Retry buttons in `WorkflowSettings.vue` and `TriggerSettings.vue` have no `type`, so clicking one publishes. `publish()` also ignores `publishBlocked`. Done when: Enter in any editor field and clicking Retry never publish; Publish is a plain button that refuses while publishing is blocked.
sam added the criticalbug labels 2026-11-13 02:49:19 +00:00
Author
Owner

Fixed in 757c3016. The editor is no longer a

, so implicit submission can't happen: Publish is a plain button that also refuses while publishing is blocked or a save is running. Reproduced first with a text input injected into the editor: Enter sent a workflow-definitions replace. After the change the same probe sends nothing. No test added: removing the form makes the state unrepresentable. task check passed.

Fixed in 757c3016. The editor is no longer a <form>, so implicit submission can't happen: Publish is a plain button that also refuses while publishing is blocked or a save is running. Reproduced first with a text input injected into the editor: Enter sent a workflow-definitions replace. After the change the same probe sends nothing. No test added: removing the form makes the state unrepresentable. task check passed.
sam closed this issue 2026-11-13 02:52:39 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1943