Replace remaining error text matches with typed checks #1923

Closed
opened 2026-11-12 16:35:17 +00:00 by sam · 1 comment
Owner

storage.go matches Docker "already exists"/"already in use"; worktree.go falls back to matching ErrObjectNotFound text; webui/workflows.go rebuilds an error from a status message and loses its code. Use containerd errdefs IsConflict, drop the text fallback, return the status error.

Done when no non-test code matches on err.Error().

storage.go matches Docker "already exists"/"already in use"; worktree.go falls back to matching ErrObjectNotFound text; webui/workflows.go rebuilds an error from a status message and loses its code. Use containerd errdefs IsConflict, drop the text fallback, return the status error. Done when no non-test code matches on err.Error().
sam added the chorelow labels 2026-11-12 16:35:17 +00:00
Author
Owner

Done in b25676b6: Docker volume conflicts use errdefs.IsConflict, the push path keeps only errors.Is, and checkDraft returns the status error. task check passed.

Done in b25676b6: Docker volume conflicts use errdefs.IsConflict, the push path keeps only errors.Is, and checkDraft returns the status error. task check passed.
sam closed this issue 2026-11-12 16:57:19 +00:00
sam added a new dependency 2026-11-13 02:50:46 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1923