Replace remaining error text matches with typed checks #1923
Notifications
Due Date
No due date set.
Blocks
#1920 Effective Go: critical paths
sam/archie
Reference: sam/archie#1923
Reference in new issue
Block a user
storage.go matches Docker "already exists"/"already in use"; worktree.go falls back to matching ErrObjectNotFound text; webui/workflows.go rebuilds an error from a status message and loses its code. Use containerd errdefs IsConflict, drop the text fallback, return the status error.
Done when no non-test code matches on err.Error().
Done in
b25676b6: Docker volume conflicts use errdefs.IsConflict, the push path keeps only errors.Is, and checkDraft returns the status error. task check passed.