fix(daemon): skip issue intake when the routed workflow is disabled (#1913) #1915

Merged
sam merged 2 commits from fix/1913-intake-skip-disabled into main 2026-11-12 13:44:07 +00:00
Owner

pollNATS now resolves the issue's label-routed workflow against the active definitions and the polling identity org's enablement before publishing. A disabled route logs one Info line and returns without acknowledging, so the issue is rediscovered on a later poll and picked up if the workflow is re-enabled. Read failures (org, definitions, enablement) log a Warn and fall through to publishing; no routable definition keeps the current publish-and-park behaviour. processNATSTask's park path, withdrawUnpolled and binding dispatch are unchanged.

Tests: table-driven TestPollNATSSkipsDisabledRoutedWorkflow in internal/daemon/intake_disabled_test.go covers disabled tdd/feasibility/triage routes (skipped, nothing published, no ack), enabled route (publish + ack), disabled-for-another-org, and fall-through on enablement/definitions/org read errors. The four disabled cases fail against the pre-fix code.

Verified: go test -short -count=1 ./internal/daemon/... (ok), go test -short ./internal/domain/workflow/... (ok), task check (exit 0) on the committed tree.

pollNATS now resolves the issue's label-routed workflow against the active definitions and the polling identity org's enablement before publishing. A disabled route logs one Info line and returns without acknowledging, so the issue is rediscovered on a later poll and picked up if the workflow is re-enabled. Read failures (org, definitions, enablement) log a Warn and fall through to publishing; no routable definition keeps the current publish-and-park behaviour. processNATSTask's park path, withdrawUnpolled and binding dispatch are unchanged. Tests: table-driven TestPollNATSSkipsDisabledRoutedWorkflow in internal/daemon/intake_disabled_test.go covers disabled tdd/feasibility/triage routes (skipped, nothing published, no ack), enabled route (publish + ack), disabled-for-another-org, and fall-through on enablement/definitions/org read errors. The four disabled cases fail against the pre-fix code. Verified: go test -short -count=1 ./internal/daemon/... (ok), go test -short ./internal/domain/workflow/... (ok), task check (exit 0) on the committed tree.
sam added 1 commit 2026-11-12 13:42:46 +00:00
fix(daemon): skip issue intake when the routed workflow is disabled (#1913)
Quality / check (pull_request) Canceled after 0s
ci/woodpecker/pr/quality Pipeline was successful
804d306f75
pollNATS queued every discovered issue and let the pin path park it with
'workflow triage is disabled'. Now, after the TaskByIssue existence check
and before PublishTask, the label-routed workflow is resolved against the
active definitions and checked against the identity org's enablement, the
same filter dispatchOrgBindings applies to armed bindings. A disabled
route logs one Info line and returns false without acknowledging, so the
issue is rediscovered on a later poll and picked up if the workflow is
re-enabled. Read failures of org, definitions or enablement log a Warn
and fall through to publishing; no routable definition keeps the current
publish behaviour. processNATSTask's park path is unchanged.
sam added 1 commit 2026-11-12 13:43:34 +00:00
Merge branch 'main' into fix/1913-intake-skip-disabled
Quality / check (pull_request) Successful in 8m11s
76be7b87b2
sam merged commit fbc9ed21e7 into main 2026-11-12 13:44:07 +00:00
sam deleted branch fix/1913-intake-skip-disabled 2026-11-12 13:44:07 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1915