Two copies of the public-address dial guard (alertwebhook and webfetch) #1795

Closed
opened 2026-11-07 18:40:45 +00:00 by sam · 1 comment
Owner

alertwebhook.PublicClient and webfetch each carry their own dialer that refuses private and loopback addresses. The Gateway's URL-attachment sniff (#1672) now uses the alertwebhook copy, so a webhook package owns a general egress guard. Done when one dial guard lives in a shared infrastructure package and both callers use it.

alertwebhook.PublicClient and webfetch each carry their own dialer that refuses private and loopback addresses. The Gateway's URL-attachment sniff (#1672) now uses the alertwebhook copy, so a webhook package owns a general egress guard. Done when one dial guard lives in a shared infrastructure package and both callers use it.
sam added the low label 2026-11-07 18:41:04 +00:00
sam closed this issue 2026-11-08 04:52:40 +00:00
Author
Owner

Fixed in b548cabc: internal/infrastructure/publicnet holds Public and Client; alert webhooks, the Gateway's attachment sniff and web fetch all use it. Web fetch now also refuses the benchmarking, IETF and NAT64 ranges it previously let through. task check passes.

Fixed in b548cabc: internal/infrastructure/publicnet holds Public and Client; alert webhooks, the Gateway's attachment sniff and web fetch all use it. Web fetch now also refuses the benchmarking, IETF and NAT64 ranges it previously let through. task check passes.
sam added the chore label 2026-11-12 15:51:28 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1795