Fix mobile command entry losing uncommitted text in repository settings #1708

Open
opened 2026-10-27 13:41:28 +00:00 by sam · 0 comments
Owner

Problem

The repository settings command editor uses one tag per argv argument, but looks like a normal command text field. On mobile, typing task check can leave the text visible in the input without committing it to the settings draft. Opening Review then shows empty command arrays instead of the command the user entered.

Observed on an Android phone in Settings → Repositories → Quality gate. The review displayed 0.gate changing from [[]] to [[],[]] while the editor showed task check. Adding a command creates an empty argv row, so the review can record an empty row while omitting pending text.

Reproduction

  1. Open Settings → Repositories on a mobile browser.
  2. Add a Quality gate command and type task check without separately confirming each argument as a tag.
  3. Open the change review.
  4. Observe that the entered command is absent and the diff contains empty arrays.

Expected behaviour

  • Space should behave like Enter: an unquoted, unescaped space commits the current argument as a tag, so typing task check naturally creates separate task and check arguments on mobile.
  • Quoted or escaped spaces stay inside the same argument. Repeated spaces must not create empty arguments.
  • Entering commands works naturally with a mobile keyboard, without requiring Enter after every argument.
  • Pending visible text is committed or clearly validated before opening review or saving; it must never be silently omitted.
  • Empty command rows cannot be saved as valid commands.
  • Review displays readable commands and arguments rather than only nested JSON arrays.
  • Argument boundaries, quoted arguments and literal characters remain correct; editing must not introduce shell evaluation.

Implementation notes

ui/src/settings/CommandListEditor.vue uses TagsInput, a NUL delimiter and TagsInputInput; its add() appends []. Consider a normal command text input with quote-aware argv parsing, or an explicitly mobile-friendly argument editor with reliable commit-on-blur/review behaviour.

Cover typing → review → save on mobile, quoted arguments, removal of empty rows, and editing an existing command. This issue concerns command entry in settings, separately from chat shell-tool availability.


Imported from GitHub #1678 · created 2026-10-16

## Problem The repository settings command editor uses one tag per argv argument, but looks like a normal command text field. On mobile, typing `task check` can leave the text visible in the input without committing it to the settings draft. Opening Review then shows empty command arrays instead of the command the user entered. Observed on an Android phone in Settings → Repositories → Quality gate. The review displayed `0.gate` changing from `[[]]` to `[[],[]]` while the editor showed `task check`. Adding a command creates an empty argv row, so the review can record an empty row while omitting pending text. ## Reproduction 1. Open Settings → Repositories on a mobile browser. 2. Add a Quality gate command and type `task check` without separately confirming each argument as a tag. 3. Open the change review. 4. Observe that the entered command is absent and the diff contains empty arrays. ## Expected behaviour - Space should behave like Enter: an unquoted, unescaped space commits the current argument as a tag, so typing `task check` naturally creates separate `task` and `check` arguments on mobile. - Quoted or escaped spaces stay inside the same argument. Repeated spaces must not create empty arguments. - Entering commands works naturally with a mobile keyboard, without requiring Enter after every argument. - Pending visible text is committed or clearly validated before opening review or saving; it must never be silently omitted. - Empty command rows cannot be saved as valid commands. - Review displays readable commands and arguments rather than only nested JSON arrays. - Argument boundaries, quoted arguments and literal characters remain correct; editing must not introduce shell evaluation. ## Implementation notes `ui/src/settings/CommandListEditor.vue` uses `TagsInput`, a NUL delimiter and `TagsInputInput`; its `add()` appends `[]`. Consider a normal command text input with quote-aware argv parsing, or an explicitly mobile-friendly argument editor with reliable commit-on-blur/review behaviour. Cover typing → review → save on mobile, quoted arguments, removal of empty rows, and editing an existing command. This issue concerns command entry in settings, separately from chat shell-tool availability. --- _Imported from GitHub #1678 · created 2026-10-16_
sam self-assigned this 2026-10-27 13:41:28 +00:00
sam added the bugmedium labels 2026-11-14 14:45:44 +00:00
sam added the deferred label 2026-11-15 17:26:14 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1708