CRITICAL: every JSX-based dashboard page rendered '[object Object]' instead of content #1705

Closed
opened 2026-10-27 13:41:27 +00:00 by sam · 0 comments
Owner

Found and fixed 2026-09-03 while building the bindings dashboard UI (archie-core-t2db.8), via real browser verification per AGENTS.md's UI rule -- not caught by any existing test, since unit tests render components in isolation via @testing-library/preact and never exercise the actual router/mount integration path.

Every page registered in ui/src/main.jsx's routes table (dashboard, tasks, logs, captures, mappings, skills, workflows, memory, curators, channels, settings) returns a Preact VNode from its page function (e.g. dashboardPage() returns ), but main.jsx's router passed that VNode into ui/src/base/dom.jsx's mount()/append(), which only knows how to append real DOM Nodes or String()-ify everything else -- so every page's actual content became the literal text "[object Object]" in the browser. Confirmed via git show that this bug already existed in the committed ui/dist bundle before any change tonight -- served the pre-existing bundle in isolation via a throwaway webui.Server harness and reproduced the identical failure on the stock dashboard. This shipped in the tagged v1.20.0 release earlier this session (and likely earlier releases too, pending the recent Preact migration commits cf1bce4/e5abb62) -- SAM: worth deciding whether a patch release is warranted, this ticket does not decide that.

Design

Fixed in commit 85761c4: main.jsx's show() function now detects whether route.view()'s result is a real DOM Node (only the unused comingSoon()/soon:true fallback) or a Preact VNode (every real page today), and calls Preact's own render(vnode, outlet) for the latter instead of the generic mount() helper. mount() itself and its other 4 vanilla-DOM call sites (theme icon swap, app shell mount, chat drawer no-op) are untouched -- this was the minimal-blast-radius fix, not a rewrite of the rendering bridge.

Acceptance criteria

Verified via Playwright against a real running server (not just source inspection): all 11 pre-existing pages plus the new bindings page render real content, zero occurrences of the literal string in any page's main content area. task check passes.

Notes

Closed on discovery -- already fixed, tested, and pushed in the same session that found it.

Close reason

Closed


Imported from beads archie-core-zv2t · GitHub #721 · type bug · priority P0 · created 2026-09-02 · closed 2026-09-05

Found and fixed 2026-09-03 while building the bindings dashboard UI (archie-core-t2db.8), via real browser verification per AGENTS.md's UI rule -- not caught by any existing test, since unit tests render components in isolation via @testing-library/preact and never exercise the actual router/mount integration path. Every page registered in ui/src/main.jsx's routes table (dashboard, tasks, logs, captures, mappings, skills, workflows, memory, curators, channels, settings) returns a Preact VNode from its page function (e.g. dashboardPage() returns <DashboardApp />), but main.jsx's router passed that VNode into ui/src/base/dom.jsx's mount()/append(), which only knows how to append real DOM Nodes or String()-ify everything else -- so every page's actual content became the literal text "[object Object]" in the browser. Confirmed via git show that this bug already existed in the committed ui/dist bundle before any change tonight -- served the pre-existing bundle in isolation via a throwaway webui.Server harness and reproduced the identical failure on the stock dashboard. This shipped in the tagged v1.20.0 release earlier this session (and likely earlier releases too, pending the recent Preact migration commits cf1bce4/e5abb62) -- SAM: worth deciding whether a patch release is warranted, this ticket does not decide that. ### Design Fixed in commit 85761c4: main.jsx's show() function now detects whether route.view()'s result is a real DOM Node (only the unused comingSoon()/soon:true fallback) or a Preact VNode (every real page today), and calls Preact's own render(vnode, outlet) for the latter instead of the generic mount() helper. mount() itself and its other 4 vanilla-DOM call sites (theme icon swap, app shell mount, chat drawer no-op) are untouched -- this was the minimal-blast-radius fix, not a rewrite of the rendering bridge. ### Acceptance criteria Verified via Playwright against a real running server (not just source inspection): all 11 pre-existing pages plus the new bindings page render real content, zero occurrences of the literal string in any page's main content area. task check passes. ### Notes Closed on discovery -- already fixed, tested, and pushed in the same session that found it. ### Close reason Closed --- _Imported from beads `archie-core-zv2t` · GitHub #721 · type bug · priority P0 · created 2026-09-02 · closed 2026-09-05_
sam added the criticalbug labels 2026-10-27 13:41:27 +00:00
sam self-assigned this 2026-10-27 13:41:27 +00:00
sam closed this issue 2026-10-27 13:41:28 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1705