Ship the file-writing store as the default memory engine #17

Closed
opened 2026-10-27 13:34:36 +00:00 by sam · 0 comments
Owner

Reframe internal/memory/builtin as the reference engine implementation behind the new contract, so the standard install keeps writing memories to files with no configuration and no behaviour change.

Acceptance Criteria

The builtin store implements the engine contract and registers as the default. A config that names no memory engine behaves exactly as today, verified by existing internal/memory tests continuing to pass unmodified where they assert behaviour rather than structure. Its lifecycle methods are real or explicit no-ops, not stubs that silently do nothing surprising.

Notes

Engine implementation done: internal/infrastructure/memory.BuiltinEngine
implements domain/memory.MemoryEngine over internal/memory/builtin.Store
(one per identity), fully tested including registering/running through
domain/memory.Registry. internal/memory/builtin itself is untouched, its
own tests pass unmodified.

NOT done: not wired into daemon bootstrap, and nothing selects it as
"the default" at runtime yet -- that depends on the config surface
(archie-core-1786637490043) landing first, since there's no config field
to resolve "unconfigured" to this engine until then. Leaving open rather
than closing on a partial AC match; will close once bootstrap wiring
makes it the actual running default.

Close reason

Complete: cfg.Memory.Engine now actually selects and starts an engine at
daemon boot, not just implements the contract in isolation.

internal/app/archied/bootstrap.go:setupMemoryEngine builds a
domain/memory.Registry, registers infraMemory.BuiltinEngine for
cfg.Memory.Engine == "builtin" or "" (matching applyMemoryDefaults'
resolution, so unconfigured and explicitly-builtin behave identically),
starts it, and stops it on shutdown -- rooted at workDir/memory-engine,
separate from the legacy provider's workDir/memory so the two can never
collide while both exist. Wired into Run() via setupMemoryAll
(archie-core-1786637490043's cfg.Memory.Engine validation runs first at
config load, so the switch's default case only guards drift between
that list and this one, not live operator input).

internal/memory/builtin is unchanged (verified: no diff, its tests pass
unmodified) and internal/memory.Manager (the live system-prompt/tool-call
path) does not read through this registry -- the two systems run in
parallel by design, per archie-core-1786637490069-11-e245c170's explicit
scoping. Converging them is future work, not part of this issue's AC.

go test ./... is green; task lint is 0 issues.


Imported from beads archie-core-1786637499480-370-223df308 · GitHub #391 · type feature · priority P2 · created 2026-08-08 · closed 2026-09-01

Reframe internal/memory/builtin as the reference engine implementation behind the new contract, so the standard install keeps writing memories to files with no configuration and no behaviour change. ### Acceptance Criteria The builtin store implements the engine contract and registers as the default. A config that names no memory engine behaves exactly as today, verified by existing internal/memory tests continuing to pass unmodified where they assert behaviour rather than structure. Its lifecycle methods are real or explicit no-ops, not stubs that silently do nothing surprising. ### Notes Engine implementation done: internal/infrastructure/memory.BuiltinEngine implements domain/memory.MemoryEngine over internal/memory/builtin.Store (one per identity), fully tested including registering/running through domain/memory.Registry. internal/memory/builtin itself is untouched, its own tests pass unmodified. NOT done: not wired into daemon bootstrap, and nothing selects it as "the default" at runtime yet -- that depends on the config surface (archie-core-1786637490043) landing first, since there's no config field to resolve "unconfigured" to this engine until then. Leaving open rather than closing on a partial AC match; will close once bootstrap wiring makes it the actual running default. ### Close reason Complete: cfg.Memory.Engine now actually selects and starts an engine at daemon boot, not just implements the contract in isolation. internal/app/archied/bootstrap.go:setupMemoryEngine builds a domain/memory.Registry, registers infraMemory.BuiltinEngine for cfg.Memory.Engine == "builtin" or "" (matching applyMemoryDefaults' resolution, so unconfigured and explicitly-builtin behave identically), starts it, and stops it on shutdown -- rooted at workDir/memory-engine, separate from the legacy provider's workDir/memory so the two can never collide while both exist. Wired into Run() via setupMemoryAll (archie-core-1786637490043's cfg.Memory.Engine validation runs first at config load, so the switch's default case only guards drift between that list and this one, not live operator input). internal/memory/builtin is unchanged (verified: no diff, its tests pass unmodified) and internal/memory.Manager (the live system-prompt/tool-call path) does not read through this registry -- the two systems run in parallel by design, per archie-core-1786637490069-11-e245c170's explicit scoping. Converging them is future work, not part of this issue's AC. go test ./... is green; task lint is 0 issues. --- _Imported from beads `archie-core-1786637499480-370-223df308` · GitHub #391 · type feature · priority P2 · created 2026-08-08 · closed 2026-09-01_
sam added the mediumfeature labels 2026-10-27 13:34:36 +00:00
sam self-assigned this 2026-10-27 13:34:36 +00:00
sam closed this issue 2026-10-27 13:34:36 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#17