tests: the two seams the test-run and fail-closed fixes live on are pinned only at their callees #1684

Open
opened 2026-10-27 13:41:22 +00:00 by sam · 0 comments
Owner

Two branches carry real damage if they regress, and neither is covered.

  1. internal/infrastructure/egress/proxy.go:537-541 wraps the task-tool backend in recordedTools for a recording session. Deleting that wrap leaves both proxy tests green (TestRecordedToolsPerformNoCall builds the wrapper by hand; TestRecordedSessionRecordsDeliveries drives forward() directly), and the consequence is a test run's mutating central tools executing for real. Cheapest fix: a record column on TestTaskToolsProxyConfinement (task_tools_test.go:32), asserting backend.calls == 0 and 'would call' in the body.

  2. internal/daemon/daemon.go:669-676 returns before recording when the chain is unavailable. Deleting it records a terminal dispatch failure, so a State Store blip permanently drops the capture. Cheapest fix: a row in TestBindingDispatchCreatesOneTask with an unavailable authorizer, asserting no task, no marker, and the capture still unclaimed.


Imported from beads archie-core-ywde2 · GitHub #1917 · type task · priority P3 · created 2026-10-25

Two branches carry real damage if they regress, and neither is covered. 1. internal/infrastructure/egress/proxy.go:537-541 wraps the task-tool backend in recordedTools for a recording session. Deleting that wrap leaves both proxy tests green (TestRecordedToolsPerformNoCall builds the wrapper by hand; TestRecordedSessionRecordsDeliveries drives forward() directly), and the consequence is a test run's mutating central tools executing for real. Cheapest fix: a record column on TestTaskToolsProxyConfinement (task_tools_test.go:32), asserting backend.calls == 0 and 'would call' in the body. 2. internal/daemon/daemon.go:669-676 returns before recording when the chain is unavailable. Deleting it records a terminal dispatch failure, so a State Store blip permanently drops the capture. Cheapest fix: a row in TestBindingDispatchCreatesOneTask with an unavailable authorizer, asserting no task, no marker, and the capture still unclaimed. --- _Imported from beads `archie-core-ywde2` · GitHub #1917 · type task · priority P3 · created 2026-10-25_
sam added the lowtask labels 2026-10-27 13:41:22 +00:00
sam self-assigned this 2026-10-27 13:41:22 +00:00
sam added the deferred label 2026-11-15 17:26:14 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1684