Repeated successful tool calls are never collapsed into a counted entry #1674

Closed
opened 2026-10-27 13:41:20 +00:00 by sam · 0 comments
Owner

Repeated successful tool calls are not collapsed; only repeated failures are.\n\ninternal/channels/telegram/live.go implements the collapse for failures: failureLines, failureCounts and countedToolLine rewrite an existing line into a counted form ('name - failed x5') when the same failure repeats. Nothing equivalent exists for successes, because gateway.FailureKey returns empty for a successful call, so the aggregation branch is only reached for errors.\n\nResult: 14 sequential grep calls render as 14 separate blocks instead of one counted entry.\n\nSplit out of GitHub #837 (fixed by PR #838).\n\nDirection: key successful calls the way failures are keyed (tool name + result summary) and reuse countedToolLine to collapse repeats.

Close reason

Landed in cca71a5; GitHub #840 already closed.


Imported from beads archie-core-yfsk · GitHub #840 · type bug · priority P2 · created 2026-09-17 · closed 2026-09-17

Repeated successful tool calls are not collapsed; only repeated failures are.\n\ninternal/channels/telegram/live.go implements the collapse for failures: failureLines, failureCounts and countedToolLine rewrite an existing line into a counted form ('name - failed x5') when the same failure repeats. Nothing equivalent exists for successes, because gateway.FailureKey returns empty for a successful call, so the aggregation branch is only reached for errors.\n\nResult: 14 sequential grep calls render as 14 separate blocks instead of one counted entry.\n\nSplit out of GitHub #837 (fixed by PR #838).\n\nDirection: key successful calls the way failures are keyed (tool name + result summary) and reuse countedToolLine to collapse repeats. ### Close reason Landed in cca71a5; GitHub #840 already closed. --- _Imported from beads `archie-core-yfsk` · GitHub #840 · type bug · priority P2 · created 2026-09-17 · closed 2026-09-17_
sam added the mediumbug labels 2026-10-27 13:41:20 +00:00
sam self-assigned this 2026-10-27 13:41:20 +00:00
sam closed this issue 2026-10-27 13:41:20 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1674