Remove remaining deadcode findings after confirming each has no caller #1671

Closed
opened 2026-10-27 13:41:19 +00:00 by sam · 1 comment
Owner

task deadcode (advisory) reports these as unreachable, and codegraph at HEAD 6545dc1e shows zero production callers: ReviewTaskResolver.Resolve and Dropped; workflow StageCommit and StageCommitPush; Manager.StepTypes and Providers (Manager.Registry is reached only from StepTypes, so check whether Manager is dead as a whole); Engine.Interval; ContextPressureGate.Reset; taskstate.Terminal; Loader.Overlay; setup.Run; forgerpc Server.Register (the live RegisterFor is kept); webui chatStreamSink.Delta (the handler never calls it). Also check before removing: Engine.MaxParallel, Engine.JobTimeout, worktreerpc Server.Register. egress ResolverFunc is constructed only by tests; delete it with its tests. Note: test-only callers do not count in deadcode (-test=false).

Acceptance criteria

Each symbol is checked with codegraph at HEAD, then removed with any tests that exercised only it. task deadcode no longer lists them. task check passes. Any symbol that turns out to be live is noted in the bead and left in place.


Imported from beads archie-core-yb3ox · GitHub #1675 · type task · priority P3 · created 2026-10-14

task deadcode (advisory) reports these as unreachable, and codegraph at HEAD 6545dc1e shows zero production callers: ReviewTaskResolver.Resolve and Dropped; workflow StageCommit and StageCommitPush; Manager.StepTypes and Providers (Manager.Registry is reached only from StepTypes, so check whether Manager is dead as a whole); Engine.Interval; ContextPressureGate.Reset; taskstate.Terminal; Loader.Overlay; setup.Run; forgerpc Server.Register (the live RegisterFor is kept); webui chatStreamSink.Delta (the handler never calls it). Also check before removing: Engine.MaxParallel, Engine.JobTimeout, worktreerpc Server.Register. egress ResolverFunc is constructed only by tests; delete it with its tests. Note: test-only callers do not count in deadcode (-test=false). ### Acceptance criteria Each symbol is checked with codegraph at HEAD, then removed with any tests that exercised only it. task deadcode no longer lists them. task check passes. Any symbol that turns out to be live is noted in the bead and left in place. --- _Imported from beads `archie-core-yb3ox` · GitHub #1675 · type task · priority P3 · created 2026-10-14_
sam added the lowtask labels 2026-10-27 13:41:19 +00:00
sam self-assigned this 2026-10-27 13:41:19 +00:00
Author
Owner

Triaged: no code change is needed for this. No code change is needed: the bead is already resolved at HEAD. main and the feat/1671-remove-remaining-deadcode-findings-after-confirming-each-has branch both point at e9937de (later than the issue's codegraph HEAD 6545dc1e), and none of the symbols the issue lists exist in the tree any more.

Checked symbol by symbol in /data/worktree:

Already gone (no declaration and no reference):

  • ReviewTaskResolver.Resolve / Dropped — zero matches repo-wide.
  • workflow.StageCommit / StageCommitPush — no constants/functions; only a stale comment at internal/domain/workflow/workflow.go:152.
  • Manager.StepTypes / Providers — internal/domain/workflow/vocabulary.go declares only Register, Registry, Settings.
  • Engine.Interval — no method on scheduling.Engine; Interval is an EngineConfig field (ticker.go:45) read at ticker.go:211.
  • ContextPressureGate.Reset — internal/tools/disclosure.go has only Evaluate, FilterTools, alwaysVisibleCopy.
  • taskstate.Terminal — absent; StepTerminal is the surviving function (used at internal/infrastructure/postgres/steps.go:138).
  • Loader.Overlay — absent; Resolve (loader.go:99) and Dir (loader.go:287) remain.
  • setup.Run — absent; setup.RunParams remains and is called from internal/app/archied/setup.go.
  • forgerpc.Server.Register and worktreerpc.Server.Register — only RegisterFor exists (forgerpc.go:172, worktreerpc.go:95).
  • webui chatStreamSink.Delta — absent; ToolCall and Media remain, both used at chat.go:472.
  • egress.ResolverFunc — absent, no reference in the package or its tests.

Turned out live, correctly left in place (matches the issue's own "check before removing" list):

  • scheduling.EngineConfig.MaxParallel — sizes the semaphore at ticker.go:139.
  • scheduling.EngineConfig.JobTimeout — bounds each run at ticker.go:280.
  • workflow.Manager as a whole — Registry() is called from internal/infrastructure/controlplanestore/workflow_definitions.go:21 and internal/app/agentworker/task_execution.go:312, so it is not dead.

Not verified: I could not run task deadcode. There is no deadcode task in Taskfile.yml — grepping "deadcode" across the checkout matches only .git/task.json metadata — and this run has no shell. So I verified the findings are gone by reading the code, not by re-running the advisory task.

Residual drift, outside this issue's scope: two comments still name removed symbols — internal/domain/workflow/workflow.go:152 ("StageCommitPush") and internal/app/archied/setup.go:273 ("setup.Run's doc comment"). Worth a one-line comment cleanup only, not a deadcode workflow.

Triaged: no code change is needed for this. No code change is needed: the bead is already resolved at HEAD. `main` and the `feat/1671-remove-remaining-deadcode-findings-after-confirming-each-has` branch both point at e9937de (later than the issue's codegraph HEAD 6545dc1e), and none of the symbols the issue lists exist in the tree any more. Checked symbol by symbol in /data/worktree: Already gone (no declaration and no reference): - `ReviewTaskResolver.Resolve` / `Dropped` — zero matches repo-wide. - `workflow.StageCommit` / `StageCommitPush` — no constants/functions; only a stale comment at internal/domain/workflow/workflow.go:152. - `Manager.StepTypes` / `Providers` — internal/domain/workflow/vocabulary.go declares only `Register`, `Registry`, `Settings`. - `Engine.Interval` — no method on `scheduling.Engine`; `Interval` is an `EngineConfig` field (ticker.go:45) read at ticker.go:211. - `ContextPressureGate.Reset` — internal/tools/disclosure.go has only `Evaluate`, `FilterTools`, `alwaysVisibleCopy`. - `taskstate.Terminal` — absent; `StepTerminal` is the surviving function (used at internal/infrastructure/postgres/steps.go:138). - `Loader.Overlay` — absent; `Resolve` (loader.go:99) and `Dir` (loader.go:287) remain. - `setup.Run` — absent; `setup.RunParams` remains and is called from internal/app/archied/setup.go. - `forgerpc.Server.Register` and `worktreerpc.Server.Register` — only `RegisterFor` exists (forgerpc.go:172, worktreerpc.go:95). - `webui chatStreamSink.Delta` — absent; `ToolCall` and `Media` remain, both used at chat.go:472. - `egress.ResolverFunc` — absent, no reference in the package or its tests. Turned out live, correctly left in place (matches the issue's own "check before removing" list): - `scheduling.EngineConfig.MaxParallel` — sizes the semaphore at ticker.go:139. - `scheduling.EngineConfig.JobTimeout` — bounds each run at ticker.go:280. - `workflow.Manager` as a whole — `Registry()` is called from internal/infrastructure/controlplanestore/workflow_definitions.go:21 and internal/app/agentworker/task_execution.go:312, so it is not dead. Not verified: I could not run `task deadcode`. There is no `deadcode` task in Taskfile.yml — grepping "deadcode" across the checkout matches only .git/task.json metadata — and this run has no shell. So I verified the findings are gone by reading the code, not by re-running the advisory task. Residual drift, outside this issue's scope: two comments still name removed symbols — internal/domain/workflow/workflow.go:152 ("StageCommitPush") and internal/app/archied/setup.go:273 ("setup.Run's doc comment"). Worth a one-line comment cleanup only, not a deadcode workflow.
sam closed this issue 2026-11-06 22:21:00 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1671