chore(config): ApplyOverlayValues is dead; confirm the file overlay does not need its map merge #1661

Closed
opened 2026-10-27 13:41:17 +00:00 by sam · 0 comments
Owner

Deleting the runtime config overlay left Loader.ApplyOverlay
(internal/infrastructure/configuration/loader.go:144) and ApplyOverlayValues
(apply.go:26) with no caller outside their own tests. 384 lines including
apply_test.go.

They are not simply deletable without one check first. apply.go's foldOverrides
is the fix for archie-core-e2e2 (a partial overlay silently clearing omitted
fields in map-valued config, dropping services.state.target_token). The file
overlay path reached by -config-overlay does not use it: Loader.overlayFile
decodes the overlay file directly into the same *config.Config
(loader.go:176). If that decode has the same map-value zeroing behaviour, the
guard belongs there and deleting apply.go removes the only test covering the
bug class.

Scope: determine whether the file overlay zeroes omitted fields of a
map-valued entry. If it does, that is a live bug and foldOverrides moves to
that path. If it does not, delete apply.go, apply_test.go and
Loader.ApplyOverlay outright. The control plane replaces whole documents, so
no dotted-path field merge is wanted in the new design either way.

Close reason

Answered and completed by 0ec8e6f2. The check resolved earlier than the bead knew: b1d28164/d5c9c801 already moved foldOverrides onto the file overlay path (applyOverlayFile at Loader.overlayFile, decodeMain's overlay layer and decodeFeature's overlay layer), so the file overlay folds partial map-valued entries instead of zeroing them -- it does not have the live bug. That made the runtime overlay path dead with no rescue to write: Loader.ApplyOverlay, ApplyOverlayValues and applySchedulingOverlay had zero callers anywhere in the tree once apply_test.go's coverage was already gone (ff424b70 deleted it), so 0ec8e6f2 deletes all three (49 lines, no additions). foldOverrides and its helpers stay, guarding the -config-overlay and conf.d overlay-file paths the file fixes put them on.


Imported from beads archie-core-xrux · GitHub #1153 · type task · priority P2 · created 2026-09-20 · closed 2026-10-05

Deleting the runtime config overlay left Loader.ApplyOverlay (internal/infrastructure/configuration/loader.go:144) and ApplyOverlayValues (apply.go:26) with no caller outside their own tests. 384 lines including apply_test.go. They are not simply deletable without one check first. apply.go's foldOverrides is the fix for archie-core-e2e2 (a partial overlay silently clearing omitted fields in map-valued config, dropping services.state.target_token). The file overlay path reached by -config-overlay does not use it: Loader.overlayFile decodes the overlay file directly into the same *config.Config (loader.go:176). If that decode has the same map-value zeroing behaviour, the guard belongs there and deleting apply.go removes the only test covering the bug class. Scope: determine whether the file overlay zeroes omitted fields of a map-valued entry. If it does, that is a live bug and foldOverrides moves to that path. If it does not, delete apply.go, apply_test.go and Loader.ApplyOverlay outright. The control plane replaces whole documents, so no dotted-path field merge is wanted in the new design either way. ### Close reason Answered and completed by 0ec8e6f2. The check resolved earlier than the bead knew: b1d28164/d5c9c801 already moved foldOverrides onto the file overlay path (applyOverlayFile at Loader.overlayFile, decodeMain's overlay layer and decodeFeature's overlay layer), so the file overlay folds partial map-valued entries instead of zeroing them -- it does not have the live bug. That made the runtime overlay path dead with no rescue to write: Loader.ApplyOverlay, ApplyOverlayValues and applySchedulingOverlay had zero callers anywhere in the tree once apply_test.go's coverage was already gone (ff424b70 deleted it), so 0ec8e6f2 deletes all three (49 lines, no additions). foldOverrides and its helpers stay, guarding the -config-overlay and conf.d overlay-file paths the file fixes put them on. --- _Imported from beads `archie-core-xrux` · GitHub #1153 · type task · priority P2 · created 2026-09-20 · closed 2026-10-05_
sam added the mediumtask labels 2026-10-27 13:41:17 +00:00
sam self-assigned this 2026-10-27 13:41:17 +00:00
sam closed this issue 2026-10-27 13:41:17 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1661