TestStateStoreServerOptionsTolerateTheDialersKeepalive flakes under full-suite load: it asserts at exactly its own 50s deadline #1629

Closed
opened 2026-10-27 13:41:09 +00:00 by sam · 0 comments
Owner

Symptom: task check failed at internal/app/archied with the subtest 'the_state_store's_server_options_keep_the_dialer's_watch_up' after 49.999324956s, then passed on an immediate re-run of the identical tree, and passes alone.

Cause, from state_store_keepalive_test.go:144: the subtest's success boundary (watch still up after the window) coincides with the same 50s it is allowed, so any scheduling delay under go test ./... load tips it over. Under a scoped single-package run it passes (measured 80.9s for the package, green), which is why lane-level gates never see it.

Evidence: /work/apps/archie-core at b995eac1, go test ./... -> FAIL after 50.00s; same tree, scoped go test ./internal/app/archied/ -> ok 50.014s; isolated -run TestStateStoreServerOptionsTolerateTheDialersKeepalive -v -> PASS, subtest reported at 50.00s.

Risk: the repository's definitive gate reports red for a tree that is fine, which trains the reader to re-run rather than investigate. Fix is to give the assertion margin over the deadline (or assert on a shorter window than the client's budget).

Close reason

Obsolete after ff424b70 removed the named keepalive test. Current tree contains no state_store_keepalive_test.go or named 50-second assertion; production keepalive policy remains. This closes the removed-test flake, not a claim of full-suite stability.


Imported from beads archie-core-vkl1 · GitHub #1092 · type bug · priority P2 · created 2026-09-22 · closed 2026-10-04

Symptom: `task check` failed at internal/app/archied with the subtest 'the_state_store's_server_options_keep_the_dialer's_watch_up' after 49.999324956s, then passed on an immediate re-run of the identical tree, and passes alone. Cause, from state_store_keepalive_test.go:144: the subtest's success boundary (watch still up after the window) coincides with the same 50s it is allowed, so any scheduling delay under `go test ./...` load tips it over. Under a scoped single-package run it passes (measured 80.9s for the package, green), which is why lane-level gates never see it. Evidence: /work/apps/archie-core at b995eac1, go test ./... -> FAIL after 50.00s; same tree, scoped `go test ./internal/app/archied/` -> ok 50.014s; isolated `-run TestStateStoreServerOptionsTolerateTheDialersKeepalive -v` -> PASS, subtest reported at 50.00s. Risk: the repository's definitive gate reports red for a tree that is fine, which trains the reader to re-run rather than investigate. Fix is to give the assertion margin over the deadline (or assert on a shorter window than the client's budget). ### Close reason Obsolete after ff424b70 removed the named keepalive test. Current tree contains no state_store_keepalive_test.go or named 50-second assertion; production keepalive policy remains. This closes the removed-test flake, not a claim of full-suite stability. --- _Imported from beads `archie-core-vkl1` · GitHub #1092 · type bug · priority P2 · created 2026-09-22 · closed 2026-10-04_
sam added the mediumbug labels 2026-10-27 13:41:09 +00:00
sam self-assigned this 2026-10-27 13:41:09 +00:00
sam closed this issue 2026-10-27 13:41:09 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1629