sdnotify: state the announce contract once, and cite the cross-cutting rule where it actually lives #1621

Open
opened 2026-10-27 13:41:07 +00:00 by sam · 0 comments
Owner

Reviewer findings 5 and 6 on 9f6eaccd. (5) The four announce sites (bootstrap.go:1748-1751, gateway.go:130-136, state_store.go:151-157, compose.go:203-213) agree only through hand-copied comment prose, and nothing ties them together - site 4 has already diverged, and no test would notice. Replace the paraphrase with one contract line on sdnotify.Ready: call it only after every listener the process serves is bound. (6) internal/sdnotify/sdnotify.go:12 cites docs/architecture/organisation.md for the cross-cutting rule (any layer may import it, it imports nothing of ours), but that document does not state it - the rule lives in AGENTS.md. internal/webhookguard/doc.go:5 carries the identical loose citation, so this is a pre-existing convention: fix it once rather than pointing at a rule the cited file lacks.


Imported from beads archie-core-v5n1 · GitHub #1383 · type task · priority P3 · created 2026-09-30

Reviewer findings 5 and 6 on 9f6eaccd. (5) The four announce sites (bootstrap.go:1748-1751, gateway.go:130-136, state_store.go:151-157, compose.go:203-213) agree only through hand-copied comment prose, and nothing ties them together - site 4 has already diverged, and no test would notice. Replace the paraphrase with one contract line on sdnotify.Ready: call it only after every listener the process serves is bound. (6) internal/sdnotify/sdnotify.go:12 cites docs/architecture/organisation.md for the cross-cutting rule (any layer may import it, it imports nothing of ours), but that document does not state it - the rule lives in AGENTS.md. internal/webhookguard/doc.go:5 carries the identical loose citation, so this is a pre-existing convention: fix it once rather than pointing at a rule the cited file lacks. --- _Imported from beads `archie-core-v5n1` · GitHub #1383 · type task · priority P3 · created 2026-09-30_
sam added the lowtask labels 2026-10-27 13:41:07 +00:00
sam self-assigned this 2026-10-27 13:41:07 +00:00
sam added the deferred label 2026-11-15 17:26:15 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1621