Reviewer findings 5 and 6 on 9f6eaccd. (5) The four announce sites (bootstrap.go:1748-1751, gateway.go:130-136, state_store.go:151-157, compose.go:203-213) agree only through hand-copied comment prose, and nothing ties them together - site 4 has already diverged, and no test would notice. Replace the paraphrase with one contract line on sdnotify.Ready: call it only after every listener the process serves is bound. (6) internal/sdnotify/sdnotify.go:12 cites docs/architecture/organisation.md for the cross-cutting rule (any layer may import it, it imports nothing of ours), but that document does not state it - the rule lives in AGENTS.md. internal/webhookguard/doc.go:5 carries the identical loose citation, so this is a pre-existing convention: fix it once rather than pointing at a rule the cited file lacks.
Imported from beads archie-core-v5n1 · GitHub #1383 · type task · priority P3 · created 2026-09-30
Reviewer findings 5 and 6 on 9f6eaccd. (5) The four announce sites (bootstrap.go:1748-1751, gateway.go:130-136, state_store.go:151-157, compose.go:203-213) agree only through hand-copied comment prose, and nothing ties them together - site 4 has already diverged, and no test would notice. Replace the paraphrase with one contract line on sdnotify.Ready: call it only after every listener the process serves is bound. (6) internal/sdnotify/sdnotify.go:12 cites docs/architecture/organisation.md for the cross-cutting rule (any layer may import it, it imports nothing of ours), but that document does not state it - the rule lives in AGENTS.md. internal/webhookguard/doc.go:5 carries the identical loose citation, so this is a pre-existing convention: fix it once rather than pointing at a rule the cited file lacks.
---
_Imported from beads `archie-core-v5n1` · GitHub #1383 · type task · priority P3 · created 2026-09-30_
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Reviewer findings 5 and 6 on
9f6eaccd. (5) The four announce sites (bootstrap.go:1748-1751, gateway.go:130-136, state_store.go:151-157, compose.go:203-213) agree only through hand-copied comment prose, and nothing ties them together - site 4 has already diverged, and no test would notice. Replace the paraphrase with one contract line on sdnotify.Ready: call it only after every listener the process serves is bound. (6) internal/sdnotify/sdnotify.go:12 cites docs/architecture/organisation.md for the cross-cutting rule (any layer may import it, it imports nothing of ours), but that document does not state it - the rule lives in AGENTS.md. internal/webhookguard/doc.go:5 carries the identical loose citation, so this is a pre-existing convention: fix it once rather than pointing at a rule the cited file lacks.Imported from beads
archie-core-v5n1· GitHub #1383 · type task · priority P3 · created 2026-09-30