skillcurator: nilerr finding at skillcurator.go:110 #1607

Closed
opened 2026-10-27 13:41:04 +00:00 by sam · 0 comments
Owner

task check's newly-added lint step (chore(taskfile) 60dde24) surfaced internal/infrastructure/skillcurator/skillcurator.go:110 -- returns nil despite a non-nil error at line 108 (nilerr). This is pre-existing debt, unrelated to any EDA/playbook engine work this session -- different subsystem entirely. Filed separately per this session's established pattern (see archie-core-e7bo) of not drive-by fixing unrelated findings inside an in-progress feature's tickets.

Design

Read the actual code at skillcurator.go:108-110 before fixing -- determine whether swallowing the error there was ever intentional (check git blame/history) or a genuine bug, and fix at the producer per AGENTS.md's Root-Cause Fixes rule rather than just propagating the error blindly if the surrounding contract expects a specific degrade-gracefully shape.

Acceptance criteria

golangci-lint run ./... reports zero nilerr findings in internal/infrastructure/skillcurator/. Existing skillcurator tests pass; add a test covering the error path if none currently exercises it. task check passes.

Close reason

Investigated per design notes: intentional behavior, not a bug -- confirmed against existing test coverage (skillcurator_test.go's parse-failure-doesn't-abort-batch test). Documented with a scoped nolint explaining why, not a behavior change. Commit pushed to main.


Imported from beads archie-core-uhtz · GitHub #748 · type bug · priority P3 · created 2026-09-02 · closed 2026-09-02

task check's newly-added lint step (chore(taskfile) 60dde24) surfaced internal/infrastructure/skillcurator/skillcurator.go:110 -- returns nil despite a non-nil error at line 108 (nilerr). This is pre-existing debt, unrelated to any EDA/playbook engine work this session -- different subsystem entirely. Filed separately per this session's established pattern (see archie-core-e7bo) of not drive-by fixing unrelated findings inside an in-progress feature's tickets. ### Design Read the actual code at skillcurator.go:108-110 before fixing -- determine whether swallowing the error there was ever intentional (check git blame/history) or a genuine bug, and fix at the producer per AGENTS.md's Root-Cause Fixes rule rather than just propagating the error blindly if the surrounding contract expects a specific degrade-gracefully shape. ### Acceptance criteria golangci-lint run ./... reports zero nilerr findings in internal/infrastructure/skillcurator/. Existing skillcurator tests pass; add a test covering the error path if none currently exercises it. task check passes. ### Close reason Investigated per design notes: intentional behavior, not a bug -- confirmed against existing test coverage (skillcurator_test.go's parse-failure-doesn't-abort-batch test). Documented with a scoped nolint explaining why, not a behavior change. Commit pushed to main. --- _Imported from beads `archie-core-uhtz` · GitHub #748 · type bug · priority P3 · created 2026-09-02 · closed 2026-09-02_
sam added the lowbug labels 2026-10-27 13:41:04 +00:00
sam self-assigned this 2026-10-27 13:41:04 +00:00
sam closed this issue 2026-10-27 13:41:04 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1607