staterpc: regression test for nil-Task Update InvalidArgument guard #1605

Closed
opened 2026-10-27 13:41:04 +00:00 by sam · 0 comments
Owner

f94e484 added the nil-Task guard at internal/infrastructure/staterpc/server.go:119 (codes.InvalidArgument, replacing a panicking store-layer deref) as the 'Update validation' finding fix, but no test asserts it. Add a bufconn-backed test: Update(ctx, &pb.UpdateRequest{Task: nil}) must return codes.InvalidArgument, not panic.

Close reason

Fixed in 93e36f5: TestUpdateRejectsNilTask asserts Update(nil) returns InvalidArgument through the real interceptor chain.


Imported from beads archie-core-uba5 · GitHub #820 · type task · priority P3 · created 2026-09-11 · closed 2026-09-11

f94e484 added the nil-Task guard at internal/infrastructure/staterpc/server.go:119 (codes.InvalidArgument, replacing a panicking store-layer deref) as the 'Update validation' finding fix, but no test asserts it. Add a bufconn-backed test: Update(ctx, &pb.UpdateRequest{Task: nil}) must return codes.InvalidArgument, not panic. ### Close reason Fixed in 93e36f5: TestUpdateRejectsNilTask asserts Update(nil) returns InvalidArgument through the real interceptor chain. --- _Imported from beads `archie-core-uba5` · GitHub #820 · type task · priority P3 · created 2026-09-11 · closed 2026-09-11_
sam added the lowtask labels 2026-10-27 13:41:04 +00:00
sam self-assigned this 2026-10-27 13:41:04 +00:00
sam closed this issue 2026-10-27 13:41:04 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1605