Skill curator (reference implementation) #16

Closed
opened 2026-10-27 13:34:36 +00:00 by sam · 0 comments
Owner

Ship a curator that maintains Archie's skills: reviewing, pruning, and improving skill definitions over time. One of the two consumers that validate the curator contract is general enough.

Acceptance Criteria

Registers and runs through the curator registry with no curator-specific special-casing in the runtime. Its changes to skills are observable and attributable to the curator. It operates within its declared tool set and cannot reach tools it did not declare.

Close reason

Complete, all three AC clauses. Design decided first in
docs/prds/skill-curator.md (no settled design existed for what "review,
prune, improve" means as concrete behavior): v1 is mechanical validation
plus safe whitespace normalization only -- no LLM-authored rewrites, no
deletion. See the doc for the full "why this scope, not more" reasoning.

  • Registers and runs through curator.Registry with no curator-specific
    special-casing: uses the existing Register/Runtime path unchanged
    (TestRegistersAndRunsThroughTheRegistry).
  • Its changes are observable and attributable: every write is preceded
    by an Action naming what changed and why (skill.normalized), surfaced
    through the existing curator activity tracker
    (archie-core-1786637489932, already shipped) -- no new observability
    surface needed.
  • Operates within its declared tool set: Manifest.Tools is empty, and
    nothing in the implementation ever touches Registrar.Tools
    (TestManifestDeclaresOnlySkills).

internal/infrastructure/skillcurator/{store,skillcurator}.go implement
curator.SkillStore and curator.CuratorEngine. The store deliberately does
not delegate to internal/skill.Discover, which aborts its whole call on
any one skill's parse failure -- wrong for "review each skill
independently" (TestPassReviewsEverySkillIndependently covers the
regression this would otherwise cause). Wired into
internal/app/archied/bootstrap.go:setupCurators, rooted the same way
loadWorkflows resolves skillsBase.

task check is green (full Go suite + dashboard tests).


Imported from beads archie-core-1786637499206-358-54f29252 · GitHub #379 · type feature · priority P2 · created 2026-08-08 · closed 2026-09-01

Ship a curator that maintains Archie's skills: reviewing, pruning, and improving skill definitions over time. One of the two consumers that validate the curator contract is general enough. ### Acceptance Criteria Registers and runs through the curator registry with no curator-specific special-casing in the runtime. Its changes to skills are observable and attributable to the curator. It operates within its declared tool set and cannot reach tools it did not declare. ### Close reason Complete, all three AC clauses. Design decided first in docs/prds/skill-curator.md (no settled design existed for what "review, prune, improve" means as concrete behavior): v1 is mechanical validation plus safe whitespace normalization only -- no LLM-authored rewrites, no deletion. See the doc for the full "why this scope, not more" reasoning. - Registers and runs through curator.Registry with no curator-specific special-casing: uses the existing Register/Runtime path unchanged (TestRegistersAndRunsThroughTheRegistry). - Its changes are observable and attributable: every write is preceded by an Action naming what changed and why (skill.normalized), surfaced through the existing curator activity tracker (archie-core-1786637489932, already shipped) -- no new observability surface needed. - Operates within its declared tool set: Manifest.Tools is empty, and nothing in the implementation ever touches Registrar.Tools (TestManifestDeclaresOnlySkills). internal/infrastructure/skillcurator/{store,skillcurator}.go implement curator.SkillStore and curator.CuratorEngine. The store deliberately does not delegate to internal/skill.Discover, which aborts its whole call on any one skill's parse failure -- wrong for "review each skill independently" (TestPassReviewsEverySkillIndependently covers the regression this would otherwise cause). Wired into internal/app/archied/bootstrap.go:setupCurators, rooted the same way loadWorkflows resolves skillsBase. task check is green (full Go suite + dashboard tests). --- _Imported from beads `archie-core-1786637499206-358-54f29252` · GitHub #379 · type feature · priority P2 · created 2026-08-08 · closed 2026-09-01_
sam added the mediumfeature labels 2026-10-27 13:34:36 +00:00
sam self-assigned this 2026-10-27 13:34:36 +00:00
sam closed this issue 2026-10-27 13:34:36 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#16