[bug] declared workflow outputs are not reflected in WorkflowNeeds.Captures, so a Kit-profile workflow can offer capture tools the harness cannot serve #1596

Closed
opened 2026-10-27 13:41:01 +00:00 by sam · 0 comments
Owner

Found by the t2db.43 lane (commit 4afefe08) and reported as a residual, not filed there. The output capture tools are appended by the engine at request-build time (internal/domain/workflow/outputs.go), but the dispatch-time harness check daemon.validateProfileMeetsNeeds (internal/daemon/daemon.go:1876) reads the workflow's declared needs.captures. A workflow that declares outputs: and runs under a Kit profile whose adapter serves no MCP capture config, without also declaring needs: {captures: true}, would offer tools the harness cannot serve. Failure is contained, not silent: a required output parks with 'output %q is required', an optional one is simply absent. docs/prds/workflow-call-outputs.md is silent on needs. Candidate one-line fix: derive Needs.Captures from a non-empty Outputs in WorkflowInterface.Validate/ParseWorkflowInterface, or read Outputs in validateProfileMeetsNeeds.

Acceptance criteria

a workflow that declares outputs but not needs.captures either has Captures derived, or is refused at save with a named reason; no Kit profile offers a capture tool its adapter cannot serve

Close reason

Closed


Imported from beads archie-core-tvfs · GitHub #1468 · type bug · priority P2 · created 2026-10-01 · closed 2026-10-01

Found by the t2db.43 lane (commit 4afefe08) and reported as a residual, not filed there. The output capture tools are appended by the engine at request-build time (internal/domain/workflow/outputs.go), but the dispatch-time harness check daemon.validateProfileMeetsNeeds (internal/daemon/daemon.go:1876) reads the workflow's declared needs.captures. A workflow that declares outputs: and runs under a Kit profile whose adapter serves no MCP capture config, without also declaring needs: {captures: true}, would offer tools the harness cannot serve. Failure is contained, not silent: a required output parks with 'output %q is required', an optional one is simply absent. docs/prds/workflow-call-outputs.md is silent on needs. Candidate one-line fix: derive Needs.Captures from a non-empty Outputs in WorkflowInterface.Validate/ParseWorkflowInterface, or read Outputs in validateProfileMeetsNeeds. ### Acceptance criteria a workflow that declares outputs but not needs.captures either has Captures derived, or is refused at save with a named reason; no Kit profile offers a capture tool its adapter cannot serve ### Close reason Closed --- _Imported from beads `archie-core-tvfs` · GitHub #1468 · type bug · priority P2 · created 2026-10-01 · closed 2026-10-01_
sam added the mediumbug labels 2026-10-27 13:41:01 +00:00
sam self-assigned this 2026-10-27 13:41:01 +00:00
sam closed this issue 2026-10-27 13:41:02 +00:00
sam added a new dependency 2026-10-27 13:42:27 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1596