gate-evidence removedAssertions heuristic false-positives on validation consolidation #1588

Open
opened 2026-10-27 13:41:00 +00:00 by sam · 0 comments
Owner

SECOND INSTANCE (recurring, not a one-off). The heuristic now fails the gate on legitimate DELETIONS as well as consolidations: (a) internal/domain/storepkg/descriptor.go replaced an inline validation loop with a call to the consolidating validator while ADDING table cases - reported fail on removedAssertions=1; (b) a revert dropped a dead feature together with its own 6 tests (a checkpoint writer whose only reader had no production caller) and ADDED one regression test proving the removal - reported fail on removedAssertions=48, removedTests=6, netAssertions=-44. Both were merged on captain inspection, which means the flag no longer predicts anything: it fires on the two most legitimate shapes a change can take. A detector the captain routinely overrides is worse than no detector, because the override becomes habit. Prefer reporting deletions as a distinct review signal the captain must acknowledge, rather than as gateResult=fail, and reserve fail for a change whose net behaviour shrinks while its tests were edited to match.

Acceptance criteria

a validation-consolidating commit with added table cases and unchanged behaviour reports gateResult pass; a commit that genuinely deletes an assertion still reports detected


Imported from beads archie-core-thce · GitHub #1381 · type bug · priority P3 · created 2026-10-01

SECOND INSTANCE (recurring, not a one-off). The heuristic now fails the gate on legitimate DELETIONS as well as consolidations: (a) internal/domain/storepkg/descriptor.go replaced an inline validation loop with a call to the consolidating validator while ADDING table cases - reported fail on removedAssertions=1; (b) a revert dropped a dead feature together with its own 6 tests (a checkpoint writer whose only reader had no production caller) and ADDED one regression test proving the removal - reported fail on removedAssertions=48, removedTests=6, netAssertions=-44. Both were merged on captain inspection, which means the flag no longer predicts anything: it fires on the two most legitimate shapes a change can take. A detector the captain routinely overrides is worse than no detector, because the override becomes habit. Prefer reporting deletions as a distinct review signal the captain must acknowledge, rather than as gateResult=fail, and reserve fail for a change whose net behaviour shrinks while its tests were edited to match. ### Acceptance criteria a validation-consolidating commit with added table cases and unchanged behaviour reports gateResult pass; a commit that genuinely deletes an assertion still reports detected --- _Imported from beads `archie-core-thce` · GitHub #1381 · type bug · priority P3 · created 2026-10-01_
sam added the lowbug labels 2026-10-27 13:41:00 +00:00
sam self-assigned this 2026-10-27 13:41:00 +00:00
sam added the deferred label 2026-11-15 17:26:16 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1588