decide(controlplane): plugin-settings accepts four directory settings unvalidated #1583

Closed
opened 2026-10-27 13:40:58 +00:00 by sam · 0 comments
Owner

internal/app/controlplane/operational_settings.go:44-57 - the PluginSettingsKind validator (now named validatePluginSettings) returns nil for every document, so plugin_dir, module_dir, secret_engine_dir and skills_dir are accepted unvalidated by the resource, and configuration.Validate has no say over them either since the validation split moved database-owned fields off the file load path. Both layers agree the value is fine because neither applies a rule.

Pre-existing and untouched by cp/config (identical on main), so it did not hold that branch. The lane record the four paths explicitly as free-form and named the function so the place to add a rule is obvious, rather than inventing rules (are the paths absolute? must skills_dir be under plugin_dir?) inside a review fix.

Decision needed: what the rules are, if any. Close it either by adding a real validator or by recording deliberately that these are free-form operator paths with no constraints.

Close reason

Closed on GitHub with verification evidence; confirmed against the tree.


Imported from beads archie-core-t3ss · GitHub #1143 · type decision · priority P2 · created 2026-09-21 · closed 2026-10-05

internal/app/controlplane/operational_settings.go:44-57 - the PluginSettingsKind validator (now named validatePluginSettings) returns nil for every document, so plugin_dir, module_dir, secret_engine_dir and skills_dir are accepted unvalidated by the resource, and configuration.Validate has no say over them either since the validation split moved database-owned fields off the file load path. Both layers agree the value is fine because neither applies a rule. Pre-existing and untouched by cp/config (identical on main), so it did not hold that branch. The lane record the four paths explicitly as free-form and named the function so the place to add a rule is obvious, rather than inventing rules (are the paths absolute? must skills_dir be under plugin_dir?) inside a review fix. Decision needed: what the rules are, if any. Close it either by adding a real validator or by recording deliberately that these are free-form operator paths with no constraints. ### Close reason Closed on GitHub with verification evidence; confirmed against the tree. --- _Imported from beads `archie-core-t3ss` · GitHub #1143 · type decision · priority P2 · created 2026-09-21 · closed 2026-10-05_
sam added the mediumdecision labels 2026-10-27 13:40:58 +00:00
sam self-assigned this 2026-10-27 13:40:58 +00:00
sam closed this issue 2026-10-27 13:40:58 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1583