Built-in workflows all require a repository #1578

Closed
opened 2026-10-27 13:40:57 +00:00 by sam · 1 comment
Owner

Every shipped workflow (feasibility, implement, pr-review, remediate, tdd, triage) declares repository: required, so the dashboard quick-start can never start a task from a prompt alone and always opens the full form. Done when at least one general-purpose workflow declares repository none/optional and a prompt-only Run starts a task directly.


Imported from beads archie-core-svyqw · GitHub #1719 · type task · priority P2 · created 2026-10-14

Every shipped workflow (feasibility, implement, pr-review, remediate, tdd, triage) declares repository: required, so the dashboard quick-start can never start a task from a prompt alone and always opens the full form. Done when at least one general-purpose workflow declares repository none/optional and a prompt-only Run starts a task directly. --- _Imported from beads `archie-core-svyqw` · GitHub #1719 · type task · priority P2 · created 2026-10-14_
sam added the mediumtask labels 2026-10-27 13:40:57 +00:00
sam self-assigned this 2026-10-27 13:40:57 +00:00
Author
Owner

Triaged: no code change is needed for this. No code change is needed: the issue is already resolved in this tree.

The issue's premise ("Every shipped workflow declares repository: required") is out of date for triage, and its done-criteria are met.

Verified:

  • internal/domain/workflow/shipped/triage.yaml:2 declares repository: optional. A grep for ^repository: across all six shipped YAMLs matches only that line; feasibility, implement, pr-review, remediate and tdd declare no key and so default to required. The YAMLs are the embedded source of truth (//go:embed shipped/*.yaml in internal/domain/workflow/definition.go:245).
  • Prompt-only run starts a task directly, end to end:
    • Routing: ResolveWorkflowID (internal/domain/workflow/routing.go:44-63) falls back to triage when a task names no workflow and carries no recognised label.
    • Admission: workRequestRepository (internal/webui/workflows.go) accepts an empty repository unless the mode is required — case requested == "": return "", "", 0, nil.
    • Dashboard: ui/src/dashboard/QuickTask.vue needsForm is false for optional/none, so Run posts /api/work-requests with repository: "" and routes straight to /tasks/{id} instead of opening the form. ui/src/tasks/NewTaskForm.vue:68-69 agrees (repoRequired is false for optional/none).
    • Execution: TestRepoLessTaskRunsTriageFromAPrompt (internal/domain/workflow/triage_repo_optional_test.go) runs a repository-less chat task through shipped triage in a scratch workspace, asserts the mission carries the prompt, and asserts the run completes. Its sibling TestShippedCollectionValidatesWithOptionalTriage pins that the shipped set still validates and that triage uses only repo-free step types.
  • Live evidence: this task itself is a prompt-only triage run with no repository.
  • Shipping is not gated on enablement: workflows are enabled unless an org disables them (internal/domain/workflow/task/enablement.go:12-15), so triage appears in the quick-start selector by default.

Not verified: I could not execute go test (read-only tooling, no shell), so the two tests above were read rather than run; and I did not confirm whether this change was released, as CHANGELOG.md has no entry for it under [Unreleased] or [1.61.x].

Remaining, if the operator wants it: adding a changelog line for the optional-triage change is the only gap I found — that is a follow-up, not this issue.

Triaged: no code change is needed for this. No code change is needed: the issue is already resolved in this tree. The issue's premise ("Every shipped workflow declares repository: required") is out of date for triage, and its done-criteria are met. Verified: - `internal/domain/workflow/shipped/triage.yaml:2` declares `repository: optional`. A grep for `^repository:` across all six shipped YAMLs matches only that line; feasibility, implement, pr-review, remediate and tdd declare no key and so default to `required`. The YAMLs are the embedded source of truth (`//go:embed shipped/*.yaml` in internal/domain/workflow/definition.go:245). - Prompt-only run starts a task directly, end to end: - Routing: `ResolveWorkflowID` (internal/domain/workflow/routing.go:44-63) falls back to `triage` when a task names no workflow and carries no recognised label. - Admission: `workRequestRepository` (internal/webui/workflows.go) accepts an empty repository unless the mode is `required` — `case requested == "": return "", "", 0, nil`. - Dashboard: `ui/src/dashboard/QuickTask.vue` `needsForm` is false for `optional`/`none`, so Run posts `/api/work-requests` with `repository: ""` and routes straight to `/tasks/{id}` instead of opening the form. `ui/src/tasks/NewTaskForm.vue:68-69` agrees (`repoRequired` is false for optional/none). - Execution: `TestRepoLessTaskRunsTriageFromAPrompt` (internal/domain/workflow/triage_repo_optional_test.go) runs a repository-less chat task through shipped triage in a scratch workspace, asserts the mission carries the prompt, and asserts the run completes. Its sibling `TestShippedCollectionValidatesWithOptionalTriage` pins that the shipped set still validates and that triage uses only repo-free step types. - Live evidence: this task itself is a prompt-only triage run with no repository. - Shipping is not gated on enablement: workflows are enabled unless an org disables them (internal/domain/workflow/task/enablement.go:12-15), so triage appears in the quick-start selector by default. Not verified: I could not execute `go test` (read-only tooling, no shell), so the two tests above were read rather than run; and I did not confirm whether this change was released, as CHANGELOG.md has no entry for it under [Unreleased] or [1.61.x]. Remaining, if the operator wants it: adding a changelog line for the optional-triage change is the only gap I found — that is a follow-up, not this issue.
sam closed this issue 2026-11-08 12:07:16 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1578