proto:lint fails: forge CreateReviewCommentsRequest fields 4 and 5 deleted without reservation #1570

Closed
opened 2026-10-27 13:40:55 +00:00 by sam · 0 comments
Owner

task check fails at proto:lint (buf breaking): fields 4 (event) and 5 (body) were removed from forge.v1 CreateReviewCommentsRequest. Done when the fields are reserved or the breaking baseline is updated and task check passes.

Close reason

Not a defect: worktree predated 94e6354d, so buf breaking against main saw the new fields as removed. Gate passes on main.


Imported from beads archie-core-sdbe2 · GitHub #1679 · type bug · priority P1 · created 2026-10-17 · closed 2026-10-17

task check fails at proto:lint (buf breaking): fields 4 (event) and 5 (body) were removed from forge.v1 CreateReviewCommentsRequest. Done when the fields are reserved or the breaking baseline is updated and task check passes. ### Close reason Not a defect: worktree predated 94e6354d, so buf breaking against main saw the new fields as removed. Gate passes on main. --- _Imported from beads `archie-core-sdbe2` · GitHub #1679 · type bug · priority P1 · created 2026-10-17 · closed 2026-10-17_
sam added the highbug labels 2026-10-27 13:40:55 +00:00
sam self-assigned this 2026-10-27 13:40:55 +00:00
sam closed this issue 2026-10-27 13:40:55 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1570