changes_captured key-set validation is top-level only #1566

Closed
opened 2026-10-27 13:40:54 +00:00 by sam · 0 comments
Owner

internal/webui/api_tasks_changes.go decodeCapture requires the capture payload's TOP-LEVEL key set to match the declared shape, and refuses a capture whose schema it cannot name. A renamed or dropped key INSIDE a files[] entry is not caught, because each entry decodes through task.FileChange and unknown or missing inner keys are ignored.

Impact is small and bounded: the entry renders as modified with zero counts rather than making the whole capture unreadable. A per-entry key-set check, or a strict unmarshaller on the entry type, would close it.

Close reason

files[] entries now need the exact FileChange key set (66d03210).


Imported from beads archie-core-s8so · GitHub #868 · type task · priority P3 · created 2026-09-18 · closed 2026-10-25

internal/webui/api_tasks_changes.go decodeCapture requires the capture payload's TOP-LEVEL key set to match the declared shape, and refuses a capture whose schema it cannot name. A renamed or dropped key INSIDE a files[] entry is not caught, because each entry decodes through task.FileChange and unknown or missing inner keys are ignored. Impact is small and bounded: the entry renders as modified with zero counts rather than making the whole capture unreadable. A per-entry key-set check, or a strict unmarshaller on the entry type, would close it. ### Close reason files[] entries now need the exact FileChange key set (66d03210). --- _Imported from beads `archie-core-s8so` · GitHub #868 · type task · priority P3 · created 2026-09-18 · closed 2026-10-25_
sam added the lowtask labels 2026-10-27 13:40:54 +00:00
sam self-assigned this 2026-10-27 13:40:54 +00:00
sam closed this issue 2026-10-27 13:40:54 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1566