tools/release.sh --version X --tag creates a LIGHTWEIGHT tag (git cat-file -t v1.45.0 -> commit), then prints:
tagged. push with:
git push origin main --follow-tags
git push --follow-tags pushes annotated tags only, so the release tag never leaves the machine. Observed on the v1.45.0 release: main reached origin, git ls-remote --tags origin v1.45.0 was empty, and the deploy workflow (which reads the tag pointing at HEAD) had already run green on that commit - so a release can be announced, pass CI, and ship images stamped dev, with nothing red anywhere. The tool's own warning ('pushing the commit without its tag builds images stamped dev') is therefore defeated by its own instruction.
Fix: create the tag annotated (git tag -a) so --follow-tags works, or change the printed instruction to 'git push origin main && git push origin refs/tags/vX.Y.Z'. Whichever is chosen, the release path should verify the tag exists on the remote and fail loudly if it does not - a silent dev-stamped release is the failure mode worth closing, not the missing tag.
Close reason
release.sh already tags annotated (v1.46.0 reached origin); the push instruction now names the tag and uses --atomic, so the commit cannot land without it.
Imported from beads archie-core-row4 · GitHub #1339 · type bug · priority P2 · created 2026-09-30 · closed 2026-10-05
tools/release.sh --version X --tag creates a LIGHTWEIGHT tag (git cat-file -t v1.45.0 -> commit), then prints:
tagged. push with:
git push origin main --follow-tags
git push --follow-tags pushes annotated tags only, so the release tag never leaves the machine. Observed on the v1.45.0 release: main reached origin, git ls-remote --tags origin v1.45.0 was empty, and the deploy workflow (which reads the tag pointing at HEAD) had already run green on that commit - so a release can be announced, pass CI, and ship images stamped dev, with nothing red anywhere. The tool's own warning ('pushing the commit without its tag builds images stamped dev') is therefore defeated by its own instruction.
Fix: create the tag annotated (git tag -a) so --follow-tags works, or change the printed instruction to 'git push origin main && git push origin refs/tags/vX.Y.Z'. Whichever is chosen, the release path should verify the tag exists on the remote and fail loudly if it does not - a silent dev-stamped release is the failure mode worth closing, not the missing tag.
### Close reason
release.sh already tags annotated (v1.46.0 reached origin); the push instruction now names the tag and uses --atomic, so the commit cannot land without it.
---
_Imported from beads `archie-core-row4` · GitHub #1339 · type bug · priority P2 · created 2026-09-30 · closed 2026-10-05_
sam
added the mediumbug labels 2026-10-27 13:40:51 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
tools/release.sh --version X --tag creates a LIGHTWEIGHT tag (git cat-file -t v1.45.0 -> commit), then prints:
git push --follow-tags pushes annotated tags only, so the release tag never leaves the machine. Observed on the v1.45.0 release: main reached origin, git ls-remote --tags origin v1.45.0 was empty, and the deploy workflow (which reads the tag pointing at HEAD) had already run green on that commit - so a release can be announced, pass CI, and ship images stamped dev, with nothing red anywhere. The tool's own warning ('pushing the commit without its tag builds images stamped dev') is therefore defeated by its own instruction.
Fix: create the tag annotated (git tag -a) so --follow-tags works, or change the printed instruction to 'git push origin main && git push origin refs/tags/vX.Y.Z'. Whichever is chosen, the release path should verify the tag exists on the remote and fail loudly if it does not - a silent dev-stamped release is the failure mode worth closing, not the missing tag.
Close reason
release.sh already tags annotated (v1.46.0 reached origin); the push instruction now names the tag and uses --atomic, so the commit cannot land without it.
Imported from beads
archie-core-row4· GitHub #1339 · type bug · priority P2 · created 2026-09-30 · closed 2026-10-05