curator.SessionSummary is a session identifier, not a summary - the name is a bug #1512

Closed
opened 2026-10-27 13:40:42 +00:00 by sam · 0 comments
Owner

internal/domain/curator.SessionSummary (internal/domain/curator/registrar.go:135) carries an id, the serving agent and a last-active time. It is a session REFERENCE, not a text summary, and the name actively misleads: while reviewing bead 290 the maintainer and an agent both read it as "the curator already summarises sessions", and a new capability (session digests, archie-core-22ed) was nearly closed as already-done on the strength of the name alone.

Fix: rename the type to say what it is (SessionRef or SessionInfo), update RecentSessions (registrar.go:127) and its return type, and update call sites in internal/infrastructure/sessioncurator (adapter.go, sessioncurator.go) plus the curator and sessioncurator tests.

Mechanical rename, no behaviour change. Keep it clearly distinct from the summarisation capability in archie-core-22ed - after the rename the two can no longer be confused.

Close reason

Renamed to SessionRef c67e2c83


Imported from beads archie-core-pgsb · GitHub #1123 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-17

internal/domain/curator.SessionSummary (internal/domain/curator/registrar.go:135) carries an id, the serving agent and a last-active time. It is a session REFERENCE, not a text summary, and the name actively misleads: while reviewing bead 290 the maintainer and an agent both read it as "the curator already summarises sessions", and a new capability (session digests, archie-core-22ed) was nearly closed as already-done on the strength of the name alone. Fix: rename the type to say what it is (SessionRef or SessionInfo), update RecentSessions (registrar.go:127) and its return type, and update call sites in internal/infrastructure/sessioncurator (adapter.go, sessioncurator.go) plus the curator and sessioncurator tests. Mechanical rename, no behaviour change. Keep it clearly distinct from the summarisation capability in archie-core-22ed - after the rename the two can no longer be confused. ### Close reason Renamed to SessionRef c67e2c83 --- _Imported from beads `archie-core-pgsb` · GitHub #1123 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-17_
sam added the mediumbug labels 2026-10-27 13:40:42 +00:00
sam self-assigned this 2026-10-27 13:40:42 +00:00
sam closed this issue 2026-10-27 13:40:42 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1512