P1: Fix recvcheck - mixed pointer/value receivers #1503

Closed
opened 2026-10-27 13:40:39 +00:00 by sam · 0 comments
Owner

recvcheck found mixed pointer/value receivers on:

  • Duration
  • TaskEnvelope
  • Provenance

This is a latent mutation-semantics bug - methods may not behave correctly if they expect to mutate the receiver.

Need to:

  • Audit all methods on Duration, TaskEnvelope, Provenance
  • Standardize to either all pointer receivers or all value receivers
  • Prefer pointer receivers for types that need mutation
  • Verify no behavior changes after fix

Blocked by: nothing

Close reason

Duration and TaskEnvelope were already consistent by the time this was picked up; fixed the remaining recvcheck violation on Provenance (Paths/String moved to pointer receiver to match the mutating record() method). All Provenance uses are through addressable struct fields, so build/tests are unaffected. recvcheck now reports 0 issues.


Imported from beads archie-core-p3wt · GitHub #657 · type bug · priority P1 · created 2026-08-28 · closed 2026-08-31

recvcheck found mixed pointer/value receivers on: - Duration - TaskEnvelope - Provenance This is a latent mutation-semantics bug - methods may not behave correctly if they expect to mutate the receiver. Need to: - Audit all methods on Duration, TaskEnvelope, Provenance - Standardize to either all pointer receivers or all value receivers - Prefer pointer receivers for types that need mutation - Verify no behavior changes after fix Blocked by: nothing ### Close reason Duration and TaskEnvelope were already consistent by the time this was picked up; fixed the remaining recvcheck violation on Provenance (Paths/String moved to pointer receiver to match the mutating record() method). All Provenance uses are through addressable struct fields, so build/tests are unaffected. recvcheck now reports 0 issues. --- _Imported from beads `archie-core-p3wt` · GitHub #657 · type bug · priority P1 · created 2026-08-28 · closed 2026-08-31_
sam added the highbug labels 2026-10-27 13:40:39 +00:00
sam self-assigned this 2026-10-27 13:40:39 +00:00
sam closed this issue 2026-10-27 13:40:39 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1503