Harness credentials: the dashboard's default org and a binding's empty org disagree #1502

Closed
opened 2026-10-27 13:40:39 +00:00 by sam · 1 comment
Owner

The dashboard asserts org.OrgFromContext, which is org.DefaultOrgID ("org-sys") when the request names none, while a credential binding whose Org is empty means the default org and a task run resolves config.CredentialAccess to the root org (empty). config.ContainerConfig.BoundCredentials compares the raw strings and the harness secret store keys on the raw value, so on a default install a setup session binds and stores under "org-sys", a task run reads under "", and the harness page reads "org-sys".

Evidence: internal/config/config.go (CredentialBinding.Org says empty means the default org; BoundCredentials compares b.Org != org; CredentialAccess returns cfg.Org, empty by default), internal/webui/api_harness.go (reads GetHarnessSecret with the asserted org), internal/app/archied/run_credential_resolver.go (resolves the run's org from the task identity's config), internal/infrastructure/postgres/harness_secrets.go (keys on the raw org).

Impact: on a default install, a setup login captures a token set a task run never reads, and the harness page reports the binding unconfigured. Only bindings written with org = "org-sys" work.

Fix direction: normalise the empty org to org.DefaultOrgID at the config boundary (BoundCredentials and CredentialAccess) so the run, the session, the store and the page name one org.

Done when: a setup login for a binding with no org captures a token set that a subsequent task run injects and the harness page shows captured.

Notes

Fixed in e2edc1bd; verified in HEAD 5124bfd4. Closing as already shipped.

Close reason

Closed


Imported from beads archie-core-p3t1 · GitHub #1518 · type bug · priority P1 · created 2026-10-08 · closed 2026-10-10

The dashboard asserts org.OrgFromContext, which is org.DefaultOrgID ("org-sys") when the request names none, while a credential binding whose Org is empty means the default org and a task run resolves config.CredentialAccess to the root org (empty). config.ContainerConfig.BoundCredentials compares the raw strings and the harness secret store keys on the raw value, so on a default install a setup session binds and stores under "org-sys", a task run reads under "", and the harness page reads "org-sys". Evidence: internal/config/config.go (CredentialBinding.Org says empty means the default org; BoundCredentials compares b.Org != org; CredentialAccess returns cfg.Org, empty by default), internal/webui/api_harness.go (reads GetHarnessSecret with the asserted org), internal/app/archied/run_credential_resolver.go (resolves the run's org from the task identity's config), internal/infrastructure/postgres/harness_secrets.go (keys on the raw org). Impact: on a default install, a setup login captures a token set a task run never reads, and the harness page reports the binding unconfigured. Only bindings written with org = "org-sys" work. Fix direction: normalise the empty org to org.DefaultOrgID at the config boundary (BoundCredentials and CredentialAccess) so the run, the session, the store and the page name one org. Done when: a setup login for a binding with no org captures a token set that a subsequent task run injects and the harness page shows captured. ### Notes Fixed in e2edc1bd; verified in HEAD 5124bfd4. Closing as already shipped. ### Close reason Closed --- _Imported from beads `archie-core-p3t1` · GitHub #1518 · type bug · priority P1 · created 2026-10-08 · closed 2026-10-10_
sam added the highbug labels 2026-10-27 13:40:39 +00:00
sam self-assigned this 2026-10-27 13:40:39 +00:00
sam closed this issue 2026-10-27 13:40:39 +00:00
Author
Owner

sam wrote (originally 2026-10-08):

Fixed default-org normalization at config credential access/binding lookup/duplicate validation, and used canonical org in Kit launch. Regression table failed against old tree and now passes. Real PostgreSQL encrypted OAuth acceptance under race detector: setup response captured; subsequent run replaces sentinel with captured token; harness API reports captured. Catalog response and token endpoint were acceptance fixtures; proxy capture/injection and encrypted storage were real. Full task check passed. Commit e2edc1bd, pushed branch and main.

_sam wrote (originally 2026-10-08):_ Fixed default-org normalization at config credential access/binding lookup/duplicate validation, and used canonical org in Kit launch. Regression table failed against old tree and now passes. Real PostgreSQL encrypted OAuth acceptance under race detector: setup response captured; subsequent run replaces sentinel with captured token; harness API reports captured. Catalog response and token endpoint were acceptance fixtures; proxy capture/injection and encrypted storage were real. Full task check passed. Commit e2edc1bd, pushed branch and main.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1502