sandbox-kit-spec v3.0.0-m.8 migration: fetch.Assemble and spec.Phases #1498

Closed
opened 2026-10-27 13:40:38 +00:00 by sam · 0 comments
Owner

The dependency bump to sandbox-kit-spec v3.0.0-m.8 was committed without adapting the code, so main did not compile. Two API changes:

  • CredentialCapability.Phase is now spec.Phases (a string or a list), not a string. internal/infrastructure/egress/credentials.go and oauth.go compared c.Phase == "runtime"; the correct adaptation is set membership (slices.Contains), and a credential naming both install and runtime must apply in both phases.
  • Client.Assemble(ctx, reqs, spec.MergeOptions) became the package function fetch.Assemble(ctx, reqs, fetch.Options), which takes a Loader, a LayerValidator and a CapabilitySelector instead of merge options. internal/infrastructure/kitrun/read must supply them.

The second is security-relevant: m.8 documents that the caller becomes responsible for layer integrity, safe extraction, resource limits and cross-Kit collisions. Migrate deliberately with those responsibilities named.

Main was restored by pinning the module back to m.6 (commit 7438c321). This bead is the migration that pin defers.

Done when: the module is at m.8+, the tree builds, and a Kit launch still refuses unsupported capabilities and unsafe layers.

Close reason

Duplicate of archie-core-egkf.16, which already tracks the m.8 migration. Recorded there: the tree is currently pinned to m.6 (commit 7438c321) to restore a buildable main, and the migration must also unpin and adapt CredentialCapability.Phase (now spec.Phases).


Imported from beads archie-core-ozda · GitHub #1513 · type bug · priority P1 · created 2026-10-09 · closed 2026-10-09

The dependency bump to sandbox-kit-spec v3.0.0-m.8 was committed without adapting the code, so main did not compile. Two API changes: - CredentialCapability.Phase is now spec.Phases (a string or a list), not a string. internal/infrastructure/egress/credentials.go and oauth.go compared c.Phase == "runtime"; the correct adaptation is set membership (slices.Contains), and a credential naming both install and runtime must apply in both phases. - Client.Assemble(ctx, reqs, spec.MergeOptions) became the package function fetch.Assemble(ctx, reqs, fetch.Options), which takes a Loader, a LayerValidator and a CapabilitySelector instead of merge options. internal/infrastructure/kitrun/read must supply them. The second is security-relevant: m.8 documents that the caller becomes responsible for layer integrity, safe extraction, resource limits and cross-Kit collisions. Migrate deliberately with those responsibilities named. Main was restored by pinning the module back to m.6 (commit 7438c321). This bead is the migration that pin defers. Done when: the module is at m.8+, the tree builds, and a Kit launch still refuses unsupported capabilities and unsafe layers. ### Close reason Duplicate of archie-core-egkf.16, which already tracks the m.8 migration. Recorded there: the tree is currently pinned to m.6 (commit 7438c321) to restore a buildable main, and the migration must also unpin and adapt CredentialCapability.Phase (now spec.Phases). --- _Imported from beads `archie-core-ozda` · GitHub #1513 · type bug · priority P1 · created 2026-10-09 · closed 2026-10-09_
sam added the highbug labels 2026-10-27 13:40:38 +00:00
sam self-assigned this 2026-10-27 13:40:38 +00:00
sam closed this issue 2026-10-27 13:40:38 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1498