dashboard chat: follow the messaging signature flip + verify SSE/history #1483

Closed
opened 2026-10-27 13:40:34 +00:00 by sam · 0 comments
Owner

Behavioural verification only. archie-core-9g5e (closed, merged 23e29b0) already
flipped the channel boundary onto domain/messaging.Message. internal/webui's
construction site changed and the dashboard now receives the canonical ID.

Verify SSE streaming and chat history are unaffected, and that api_chat_test.go's
strengthened assertion (MessageID now non-empty on the messages endpoint) holds.
If the conversion-back in chat_local.go no longer matches the state 9g5e
produced, reconcile it here.

SEQUENCING: this bead and archie-core-8cda.5.3 (migrate dashboard data APIs to
State Store read contracts) both rewrite dashboard-facing paths. Land this one
first so 5.3 hits the final shape once rather than twice.

Close reason

Verification-only, no code change required. 9g5e already left the dashboard path coherent: FromStoredMessage/ToStoredMessage are gone everywhere, decodeChatMessage builds gateway.Inbound{Message: messaging.Message{RoleUser, ConversationID from ChannelID}, Page} with Page never persisted, and api_chat.go:191 emits MessageID: string(message.ID) so the canonical ID reaches the dashboard. Ran the webui chat/SSE suite: TestChatStreamCarriesCurrentPage (still asserts Page != '/tasks'), TestChatSessionAndMessageEndpoints/messages (strengthened MessageID != '' assertion holds), and all TestSSEStream*/TestChatStream* pass. No regression from the 9g5e flip.


Imported from beads archie-core-o4e4 · GitHub #666 · type task · priority P2 · created 2026-08-31 · closed 2026-09-08

Behavioural verification only. archie-core-9g5e (closed, merged 23e29b0) already flipped the channel boundary onto domain/messaging.Message. internal/webui's construction site changed and the dashboard now receives the canonical ID. Verify SSE streaming and chat history are unaffected, and that api_chat_test.go's strengthened assertion (MessageID now non-empty on the messages endpoint) holds. If the conversion-back in chat_local.go no longer matches the state 9g5e produced, reconcile it here. SEQUENCING: this bead and archie-core-8cda.5.3 (migrate dashboard data APIs to State Store read contracts) both rewrite dashboard-facing paths. Land this one first so 5.3 hits the final shape once rather than twice. ### Close reason Verification-only, no code change required. 9g5e already left the dashboard path coherent: FromStoredMessage/ToStoredMessage are gone everywhere, decodeChatMessage builds gateway.Inbound{Message: messaging.Message{RoleUser, ConversationID from ChannelID}, Page} with Page never persisted, and api_chat.go:191 emits MessageID: string(message.ID) so the canonical ID reaches the dashboard. Ran the webui chat/SSE suite: TestChatStreamCarriesCurrentPage (still asserts Page != '/tasks'), TestChatSessionAndMessageEndpoints/messages (strengthened MessageID != '' assertion holds), and all TestSSEStream*/TestChatStream* pass. No regression from the 9g5e flip. --- _Imported from beads `archie-core-o4e4` · GitHub #666 · type task · priority P2 · created 2026-08-31 · closed 2026-09-08_
sam added the mediumtask labels 2026-10-27 13:40:34 +00:00
sam self-assigned this 2026-10-27 13:40:34 +00:00
sam closed this issue 2026-10-27 13:40:35 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1483