An empty repo base reaches worktree.Prepare raw, so the default main never applies #1439

Closed
opened 2026-10-27 13:40:24 +00:00 by sam · 0 comments
Owner

Found while answering whether a newly added repository row in the Web UI should prefill base/ecosystem (the editor's literal per-path skeletons were retired in aa650e2c, so a new row now starts from the derived schema's blank values).

EVIDENCE (current main)

  • internal/config/config.go:154-159: BaseBranch() maps an empty repo base to "main".
  • internal/daemon/daemon.go:1178 passes the RAW field: trees.Prepare(ctx, task.Owner, task.Repo, repo.Base, task.IssueNumber, ...). So a repo whose base is empty hands "" to Prepare and the mapped default never applies.

The config skill already records repository base as partially-wired with exactly this note ("BaseBranch() maps empty to main, but daemon.process pre-clones with raw repo.Base. Set it explicitly."), evidenced 2026-09-18; this confirms it still holds and adds the live consequence: the Web UI's repository row used to prefill base: "main" from a hardcoded skeleton, which hid this. That skeleton is gone, so a repository added through the dashboard can now carry an empty base.

Contrast ecosystem, which is safe blank: the resolved preflight/test-glob path treats an empty ecosystem as Go, so only base has teeth.

FIX DIRECTION

Use BaseBranch() at the site that prepares the worktree (root-cause; one call site), rather than teaching the Web UI to prefill a value the domain already defines. Prefilling in the UI would put a domain default in a third home: the schema would need a default tag, the skeleton already had one, and BaseBranch() has the real one.

Related: archie-core-4w0c (schedules interval as a bare time.Duration) and archie-core-q4og (container-runtime-policies untagged) are the same audit's other findings.

Close reason

Already landed before filing: 3d49d919 (an ancestor of current HEAD) cuts worktrees from the mapped base branch, and internal/daemon/daemon.go's trees.Prepare call carries repo.BaseBranch() so a declared base is honoured instead of reaching Prepare raw. The GitHub mirror was closed completed with the tree check performed; the bead's subject is the same fix.


Imported from beads archie-core-lwzd · GitHub #1168 · type bug · priority P3 · created 2026-09-21 · closed 2026-09-29

Found while answering whether a newly added repository row in the Web UI should prefill base/ecosystem (the editor's literal per-path skeletons were retired in aa650e2c, so a new row now starts from the derived schema's blank values). EVIDENCE (current main) - internal/config/config.go:154-159: BaseBranch() maps an empty repo base to "main". - internal/daemon/daemon.go:1178 passes the RAW field: trees.Prepare(ctx, task.Owner, task.Repo, repo.Base, task.IssueNumber, ...). So a repo whose base is empty hands "" to Prepare and the mapped default never applies. The config skill already records repository base as *partially-wired* with exactly this note ("BaseBranch() maps empty to main, but daemon.process pre-clones with raw repo.Base. Set it explicitly."), evidenced 2026-09-18; this confirms it still holds and adds the live consequence: the Web UI's repository row used to prefill base: "main" from a hardcoded skeleton, which hid this. That skeleton is gone, so a repository added through the dashboard can now carry an empty base. Contrast ecosystem, which is safe blank: the resolved preflight/test-glob path treats an empty ecosystem as Go, so only base has teeth. FIX DIRECTION Use BaseBranch() at the site that prepares the worktree (root-cause; one call site), rather than teaching the Web UI to prefill a value the domain already defines. Prefilling in the UI would put a domain default in a third home: the schema would need a default tag, the skeleton already had one, and BaseBranch() has the real one. Related: archie-core-4w0c (schedules interval as a bare time.Duration) and archie-core-q4og (container-runtime-policies untagged) are the same audit's other findings. ### Close reason Already landed before filing: 3d49d919 (an ancestor of current HEAD) cuts worktrees from the mapped base branch, and internal/daemon/daemon.go's trees.Prepare call carries repo.BaseBranch() so a declared base is honoured instead of reaching Prepare raw. The GitHub mirror was closed completed with the tree check performed; the bead's subject is the same fix. --- _Imported from beads `archie-core-lwzd` · GitHub #1168 · type bug · priority P3 · created 2026-09-21 · closed 2026-09-29_
sam added the lowbug labels 2026-10-27 13:40:24 +00:00
sam self-assigned this 2026-10-27 13:40:24 +00:00
sam closed this issue 2026-10-27 13:40:24 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1439