tests that seed a temporary git repo inherit the developer's global commit.gpgsign and fail without an agent socket #1414

Closed
opened 2026-10-27 13:40:18 +00:00 by sam · 0 comments
Owner

On a host with commit.gpgsign=true and gpg.format=ssh, 'task check' is red on a clean main for a reason that has nothing to do with the code: every failure is 'git commit' dying with 'error: Couldn't get agent socket? / fatal: failed to write commit object' (internal/agentexec, internal/app/agentworker, internal/domain/workflow and others that seed a temp repo). Running the same package with GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=commit.gpgsign GIT_CONFIG_VALUE_0=false turns it green, so the tree is fine and the environment is the variable. Consequence for the fleet: every lane gate and every merge-train gate reports failures that are indistinguishable from real regressions, and the first diagnosis costs a full gate run each time. Fix at the producer: whatever helper seeds a test repository (in _test.go, not in a shipped file) should write commit.gpgsign=false into the temp repo's own config, so a test never depends on the developer's global git identity or an ssh agent. Accept the same override via env if a test cannot own its repo config.

Acceptance criteria

on a host with global commit.gpgsign=true and no SSH_AUTH_SOCK, go test ./internal/agentexec/ ... ./internal/app/agentworker/ ... passes without any GIT_CONFIG_* override; the fix lives in test helpers, not in production code

Close reason

Closed


Imported from beads archie-core-kcpr · GitHub #1467 · type bug · priority P2 · created 2026-10-01 · closed 2026-10-01

On a host with commit.gpgsign=true and gpg.format=ssh, 'task check' is red on a clean main for a reason that has nothing to do with the code: every failure is 'git commit' dying with 'error: Couldn't get agent socket? / fatal: failed to write commit object' (internal/agentexec, internal/app/agentworker, internal/domain/workflow and others that seed a temp repo). Running the same package with GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=commit.gpgsign GIT_CONFIG_VALUE_0=false turns it green, so the tree is fine and the environment is the variable. Consequence for the fleet: every lane gate and every merge-train gate reports failures that are indistinguishable from real regressions, and the first diagnosis costs a full gate run each time. Fix at the producer: whatever helper seeds a test repository (in _test.go, not in a shipped file) should write commit.gpgsign=false into the temp repo's own config, so a test never depends on the developer's global git identity or an ssh agent. Accept the same override via env if a test cannot own its repo config. ### Acceptance criteria on a host with global commit.gpgsign=true and no SSH_AUTH_SOCK, go test ./internal/agentexec/ ... ./internal/app/agentworker/ ... passes without any GIT_CONFIG_* override; the fix lives in test helpers, not in production code ### Close reason Closed --- _Imported from beads `archie-core-kcpr` · GitHub #1467 · type bug · priority P2 · created 2026-10-01 · closed 2026-10-01_
sam added the mediumbug labels 2026-10-27 13:40:18 +00:00
sam self-assigned this 2026-10-27 13:40:18 +00:00
sam closed this issue 2026-10-27 13:40:18 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1414