GetHarnessSecret trusts the org named in the request #1401

Closed
opened 2026-10-27 13:40:15 +00:00 by sam · 1 comment
Owner

The GetHarnessSecret RPC reads the org from the request body rather than the caller, so any holder of the instance credential can read another org's harness token set. Derive the org from the caller like every other State Store RPC. Done when the request field is gone and a caller cannot name another org.

Acceptance criteria

GetHarnessSecret derives org scope from the caller and no longer accepts an org from the request.

Close reason

Removed org fields from harness-secret inputs. State Store derives scope from the authenticated caller or a live grant's stored task. Launcher and proxy forward run grants; setup streams forward and resolve the principal and reject another org. Regression tests cover legacy forged org fields, cross-org denial, revocation, and OAuth injection/refresh. Full task check passed; commit d0f4842c.


Imported from beads archie-core-jo15w · GitHub #1582 · type bug · priority P2 · created 2026-10-10 · closed 2026-10-17

The GetHarnessSecret RPC reads the org from the request body rather than the caller, so any holder of the instance credential can read another org's harness token set. Derive the org from the caller like every other State Store RPC. Done when the request field is gone and a caller cannot name another org. ### Acceptance criteria GetHarnessSecret derives org scope from the caller and no longer accepts an org from the request. ### Close reason Removed org fields from harness-secret inputs. State Store derives scope from the authenticated caller or a live grant's stored task. Launcher and proxy forward run grants; setup streams forward and resolve the principal and reject another org. Regression tests cover legacy forged org fields, cross-org denial, revocation, and OAuth injection/refresh. Full task check passed; commit d0f4842c. --- _Imported from beads `archie-core-jo15w` · GitHub #1582 · type bug · priority P2 · created 2026-10-10 · closed 2026-10-17_
sam added the mediumbug labels 2026-10-27 13:40:15 +00:00
sam self-assigned this 2026-10-27 13:40:15 +00:00
sam closed this issue 2026-10-27 13:40:15 +00:00
Author
Owner

sam wrote (originally 2026-10-13):

Partial fix in the staterpc commit: org-scoped callers are confined. The instance credential can still name any org; tracked in the follow-up bead for deriving the org from the task grant.

_sam wrote (originally 2026-10-13):_ Partial fix in the staterpc commit: org-scoped callers are confined. The instance credential can still name any org; tracked in the follow-up bead for deriving the org from the task grant.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1401