Structured configuration editors: repositories, maps #138

Closed
opened 2026-10-27 13:35:06 +00:00 by sam · 0 comments
Owner

Repositories currently render as a static read-only table missing AllowConcurrent, MaxRetries, and ReviewEnabled entirely (ReviewEnabled is absent from RepoView in api_config.go, not just unrendered). Add ReviewEnabled to RepoView, and build a dedicated backend-defined editor for the repositories section (and the models/providers maps) so these stop being silently read-only. This is the concrete fix for the allow_concurrent discoverability gap Sam hit, delivered as a typed editor rather than a one-off card patch, since the schema this epic introduces is what should own its shape.

Close reason

Scoped to visibility, not full inline editing -- while implementing, found that the dashboard's PATCH /api/config path (overlay.Nest + configuration.ApplyOverlayValues) has no array-index support, so a per-element update to the Repos slice cannot be expressed as a dotted key today. That's real, separate scope, filed as archie-core-b6ew.6 rather than bolted on.

Shipped: RepoView.ReviewEnabled (previously absent from the API entirely, not just unrendered) alongside AllowConcurrent and MaxRetries; the repositories card now shows Concurrent/Max retries/Self-review columns as read-only pills, closing the concrete discoverability gap (Sam couldn't see allow_concurrent without an agent tracing Go source). config.example.toml documents review_enabled, which was undocumented before this. Go test pins ReviewEnabled reaching ConfigView for both a configured and a zero-value repo.


Imported from beads archie-core-b6ew.4 · GitHub #691 · type feature · priority P2 · created 2026-09-02 · closed 2026-09-02

Repositories currently render as a static read-only table missing AllowConcurrent, MaxRetries, and ReviewEnabled entirely (ReviewEnabled is absent from RepoView in api_config.go, not just unrendered). Add ReviewEnabled to RepoView, and build a dedicated backend-defined editor for the repositories section (and the models/providers maps) so these stop being silently read-only. This is the concrete fix for the allow_concurrent discoverability gap Sam hit, delivered as a typed editor rather than a one-off card patch, since the schema this epic introduces is what should own its shape. ### Close reason Scoped to visibility, not full inline editing -- while implementing, found that the dashboard's PATCH /api/config path (overlay.Nest + configuration.ApplyOverlayValues) has no array-index support, so a per-element update to the Repos slice cannot be expressed as a dotted key today. That's real, separate scope, filed as archie-core-b6ew.6 rather than bolted on. Shipped: RepoView.ReviewEnabled (previously absent from the API entirely, not just unrendered) alongside AllowConcurrent and MaxRetries; the repositories card now shows Concurrent/Max retries/Self-review columns as read-only pills, closing the concrete discoverability gap (Sam couldn't see allow_concurrent without an agent tracing Go source). config.example.toml documents review_enabled, which was undocumented before this. Go test pins ReviewEnabled reaching ConfigView for both a configured and a zero-value repo. --- _Imported from beads `archie-core-b6ew.4` · GitHub #691 · type feature · priority P2 · created 2026-09-02 · closed 2026-09-02_
sam added the mediumfeature labels 2026-10-27 13:35:06 +00:00
sam self-assigned this 2026-10-27 13:35:06 +00:00
sam closed this issue 2026-10-27 13:35:06 +00:00
sam added a new dependency 2026-10-27 13:41:45 +00:00
sam added a new dependency 2026-10-27 13:41:46 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#138