Finish UI dependency installation before Go gate scans #1375

Closed
opened 2026-10-27 13:40:08 +00:00 by sam · 0 comments
Owner

task check:readonly runs Go tests, vet, lint, and builds concurrently with ui:deps npm install. On a checkout with stale node_modules, npm removes packages containing Go sources while go test ./... and golangci-lint scan them; observed flatted/golang/pkg/flatted typecheck and missing-directory failures during installation. Serialize dependency mutation before the readonly checks; do not patch third-party package files.

Acceptance criteria

A gate after a UI lockfile update finishes dependency installation before Go scans begin, passes on the settled tree, and still runs independent readonly checks concurrently.

Close reason

task check installs the dashboard dependencies serially before check:readonly fans out, so a lockfile update can no longer delete node_modules Go sources while go test and golangci-lint scan them; ui:deps is run:once so the parallel UI checks reuse the settled install. Gate run after the change passes.


Imported from beads archie-core-icow · GitHub #1540 · type bug · priority P2 · created 2026-10-09 · closed 2026-10-26

task check:readonly runs Go tests, vet, lint, and builds concurrently with ui:deps npm install. On a checkout with stale node_modules, npm removes packages containing Go sources while go test ./... and golangci-lint scan them; observed flatted/golang/pkg/flatted typecheck and missing-directory failures during installation. Serialize dependency mutation before the readonly checks; do not patch third-party package files. ### Acceptance criteria A gate after a UI lockfile update finishes dependency installation before Go scans begin, passes on the settled tree, and still runs independent readonly checks concurrently. ### Close reason task check installs the dashboard dependencies serially before check:readonly fans out, so a lockfile update can no longer delete node_modules Go sources while go test and golangci-lint scan them; ui:deps is run:once so the parallel UI checks reuse the settled install. Gate run after the change passes. --- _Imported from beads `archie-core-icow` · GitHub #1540 · type bug · priority P2 · created 2026-10-09 · closed 2026-10-26_
sam added the mediumbug labels 2026-10-27 13:40:08 +00:00
sam self-assigned this 2026-10-27 13:40:08 +00:00
sam closed this issue 2026-10-27 13:40:08 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1375