Telegram /approve is shadowed: task approval is unreachable and the command means two things #1365

Closed
opened 2026-10-27 13:40:06 +00:00 by sam · 0 comments
Owner

Found while making Telegram /help truthful (archie-core-1786637493230-132).

The collision

  • Shared/router semantics (spec in internal/domain/messaging/commands.go, implemented in internal/gateway/gateway.go): '/approve ' approves a WAITING TASK.
  • Telegram registers an exact local handler for the same verb (internal/channels/telegram/dangerous.go, approveHandler) which lists and approves pending DANGEROUS COMMANDS. denyHandler is its counterpart.
  • The local handler shadows the router, so on Telegram task approval via /approve is UNREACHABLE, and publishing the shared copy in /help would be a lie.

Observable consequences

  • The executable Telegram command set is messaging.LocalCommands() (29) plus Telegram-local handlers {approve, deny, rollback, stop}. Telegram publishes 30 = 29 shared - /approve + /rollback + /stop. So /deny is a real handler that appears in neither the menu nor /help, and /approve is published nowhere.
  • A Telegram user cannot approve a waiting task by the documented verb.

Why this is its own issue and not a rider on the /help work

  • Making /help truthful needs no behaviour change: publish /approve and /deny with Telegram-accurate copy and add a drift guard.
  • Resolving the semantics DOES change behaviour for a command the operator types, so it needs a deliberate decision (make /approve mean task approval and rename the dangerous-command surface, e.g. /pending), with handler and handler-test updates.

Note: the /help drift guard (published set == shared + {deny,rollback,stop}, every published command has a handler) is being added under the /help bead and does not depend on this decision.

Close reason

The Telegram-local approve and deny handlers are gone, so /approve already reaches the router's task approval. It is now published in the menu and /help.


Imported from beads archie-core-ho86 · GitHub #1113 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-10

Found while making Telegram /help truthful (archie-core-1786637493230-132). The collision - Shared/router semantics (spec in internal/domain/messaging/commands.go, implemented in internal/gateway/gateway.go): '/approve <task-id>' approves a WAITING TASK. - Telegram registers an exact local handler for the same verb (internal/channels/telegram/dangerous.go, approveHandler) which lists and approves pending DANGEROUS COMMANDS. denyHandler is its counterpart. - The local handler shadows the router, so on Telegram task approval via /approve is UNREACHABLE, and publishing the shared copy in /help would be a lie. Observable consequences - The executable Telegram command set is messaging.LocalCommands() (29) plus Telegram-local handlers {approve, deny, rollback, stop}. Telegram publishes 30 = 29 shared - /approve + /rollback + /stop. So /deny is a real handler that appears in neither the menu nor /help, and /approve is published nowhere. - A Telegram user cannot approve a waiting task by the documented verb. Why this is its own issue and not a rider on the /help work - Making /help truthful needs no behaviour change: publish /approve and /deny with Telegram-accurate copy and add a drift guard. - Resolving the semantics DOES change behaviour for a command the operator types, so it needs a deliberate decision (make /approve mean task approval and rename the dangerous-command surface, e.g. /pending), with handler and handler-test updates. Note: the /help drift guard (published set == shared + {deny,rollback,stop}, every published command has a handler) is being added under the /help bead and does not depend on this decision. ### Close reason The Telegram-local approve and deny handlers are gone, so /approve already reaches the router's task approval. It is now published in the menu and /help. --- _Imported from beads `archie-core-ho86` · GitHub #1113 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-10_
sam added the mediumbug labels 2026-10-27 13:40:06 +00:00
sam self-assigned this 2026-10-27 13:40:06 +00:00
sam closed this issue 2026-10-27 13:40:06 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1365