finalText returns the tool block alone when the reply is empty, and finalize sends it as the authoritative finished message — content == '' is the only silence path, so an empty-reply turn with completed tools permanently delivers '🔧 shell — exit 0' with no answer. The old path guarded 'if reply != ""'. Telegram messages are immutable, so it can never be corrected. Gated on show_tool_calls (off by default), so it bites opt-in deployments. No test covers finalize with an empty reply and tools.
Failure: the model ends a tool-use loop without a final summary (empty ResponseText); the finished message shows only the tool line, looking like a completed answer that said nothing.
Design
When the reply is empty, do not post the tool block as the answer — either skip the final send (leave the cursor-cleaned live message) or emit an explicit 'no reply' marker. Add a test for finalize(empty, tools).
Acceptance criteria
A turn that ends with tools but no answer text does not post a bare tool line as the final message.
Close reason
Fixed in internal/channels/telegram/live.go: framedText keeps tool lines whole ahead of the clamped answer tail (fixes wpq6); finalText appends a '(no response)' marker when tools ran but the reply is empty (fixes hlxd); abandonFailed marks a provider-error partial distinctly from a clean /stop abandon (fixes c3w2). Regression tests verified red-then-green; adversarial review found no blocking issues (added one more test for the degenerate oversized-tool-block case it flagged). task check clean, committed as 587b9b9.
Imported from beads archie-core-hlxd · GitHub #486 · type bug · priority P2 · created 2026-08-14 · closed 2026-08-14
finalText returns the tool block alone when the reply is empty, and finalize sends it as the authoritative finished message — content == '' is the only silence path, so an empty-reply turn with completed tools permanently delivers '🔧 shell — exit 0' with no answer. The old path guarded 'if reply != ""'. Telegram messages are immutable, so it can never be corrected. Gated on show_tool_calls (off by default), so it bites opt-in deployments. No test covers finalize with an empty reply and tools.
Failure: the model ends a tool-use loop without a final summary (empty ResponseText); the finished message shows only the tool line, looking like a completed answer that said nothing.
### Design
When the reply is empty, do not post the tool block as the answer — either skip the final send (leave the cursor-cleaned live message) or emit an explicit 'no reply' marker. Add a test for finalize(empty, tools).
### Acceptance criteria
A turn that ends with tools but no answer text does not post a bare tool line as the final message.
### Close reason
Fixed in internal/channels/telegram/live.go: framedText keeps tool lines whole ahead of the clamped answer tail (fixes wpq6); finalText appends a '(no response)' marker when tools ran but the reply is empty (fixes hlxd); abandonFailed marks a provider-error partial distinctly from a clean /stop abandon (fixes c3w2). Regression tests verified red-then-green; adversarial review found no blocking issues (added one more test for the degenerate oversized-tool-block case it flagged). task check clean, committed as 587b9b9.
---
_Imported from beads `archie-core-hlxd` · GitHub #486 · type bug · priority P2 · created 2026-08-14 · closed 2026-08-14_
sam
added the mediumbug labels 2026-10-27 13:40:05 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
finalText returns the tool block alone when the reply is empty, and finalize sends it as the authoritative finished message — content == '' is the only silence path, so an empty-reply turn with completed tools permanently delivers '🔧 shell — exit 0' with no answer. The old path guarded 'if reply != ""'. Telegram messages are immutable, so it can never be corrected. Gated on show_tool_calls (off by default), so it bites opt-in deployments. No test covers finalize with an empty reply and tools.
Failure: the model ends a tool-use loop without a final summary (empty ResponseText); the finished message shows only the tool line, looking like a completed answer that said nothing.
Design
When the reply is empty, do not post the tool block as the answer — either skip the final send (leave the cursor-cleaned live message) or emit an explicit 'no reply' marker. Add a test for finalize(empty, tools).
Acceptance criteria
A turn that ends with tools but no answer text does not post a bare tool line as the final message.
Close reason
Fixed in internal/channels/telegram/live.go: framedText keeps tool lines whole ahead of the clamped answer tail (fixes wpq6); finalText appends a '(no response)' marker when tools ran but the reply is empty (fixes hlxd); abandonFailed marks a provider-error partial distinctly from a clean /stop abandon (fixes c3w2). Regression tests verified red-then-green; adversarial review found no blocking issues (added one more test for the degenerate oversized-tool-block case it flagged). task check clean, committed as 587b9b9.
Imported from beads
archie-core-hlxd· GitHub #486 · type bug · priority P2 · created 2026-08-14 · closed 2026-08-14